You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2019/08/28 03:58:05 UTC

[Impala-ASF-CR] IMPALA-8897: Fully qualify all links on the webserver

Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14151


Change subject: IMPALA-8897: Fully qualify all links on the webserver
......................................................................

IMPALA-8897: Fully qualify all links on the webserver

This patch adds the 'host:port' to all links on the webserver. This
will facilitate proxying connections to the debug webui through Knox
by allowing us to create rewrite rules that do the transform:

<a href="host:port/path">...</a>
=>
<a href="<knox-host>/topology/impalaui/path?host=host&port=port">...</a>

which allows us to have a single IMPALAUI Knox service that can proxy
connections to any impalad/statestored/catalogd webui in a cluster.

Note that this works because currently all of the links on Impala's
webui are within the same webserver (it would also be possible to add
links to other Impala daemon webuis within a cluster, eg. if we wanted
to add webui links on the /backends page). If we ever need to add
links to external pages, the Knox service definition will likely need
to be modified.

Testing:
- Ran the webserver and manually clicked around on a bunch of links to
  ensure everything works as expected.
- Ran in a cluster and verified the new Knox service defintion works
  as intended with this change.
- Added a test that uses a regex to check for template files that have
  links that don't conform to this.

Change-Id: If1195709a0f21f39d9a1e484880a0c46c9967ed2
---
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
M be/src/util/webserver.cc
M be/src/util/webserver.h
M tests/common/file_utils.py
M tests/webserver/test_web_pages.py
M www/admission_controller.tmpl
M www/catalog.tmpl
M www/common-header.tmpl
M www/queries.tmpl
M www/query_detail_tabs.tmpl
M www/query_profile.tmpl
M www/sessions.tmpl
M www/threadz.tmpl
M www/threadz_tabs.tmpl
15 files changed, 81 insertions(+), 55 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/14151/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If1195709a0f21f39d9a1e484880a0c46c9967ed2
Gerrit-Change-Number: 14151
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-8897: Update debug webui to help with Apache Knox rewrite rules

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14151 )

Change subject: IMPALA-8897: Update debug webui to help with Apache Knox rewrite rules
......................................................................


Patch Set 3:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/4424/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/14151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1195709a0f21f39d9a1e484880a0c46c9967ed2
Gerrit-Change-Number: 14151
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Aug 2019 21:25:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8897: Update debug webui to help with Apache Knox rewrite rules

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.

Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14151 )

Change subject: IMPALA-8897: Update debug webui to help with Apache Knox rewrite rules
......................................................................


Patch Set 8: Code-Review+2

carrying forward


-- 
To view, visit http://gerrit.cloudera.org:8080/14151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1195709a0f21f39d9a1e484880a0c46c9967ed2
Gerrit-Change-Number: 14151
Gerrit-PatchSet: 8
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Aug 2019 19:24:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8897: Update debug webui to help with Apache Knox rewrite rules

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14151 )

Change subject: IMPALA-8897: Update debug webui to help with Apache Knox rewrite rules
......................................................................


Patch Set 9: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1195709a0f21f39d9a1e484880a0c46c9967ed2
Gerrit-Change-Number: 14151
Gerrit-PatchSet: 9
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Aug 2019 23:32:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8897: Update debug webui to help with Apache Knox rewrite rules

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.

Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14151 )

Change subject: IMPALA-8897: Update debug webui to help with Apache Knox rewrite rules
......................................................................


Patch Set 6: Code-Review+2

carrying forward


-- 
To view, visit http://gerrit.cloudera.org:8080/14151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1195709a0f21f39d9a1e484880a0c46c9967ed2
Gerrit-Change-Number: 14151
Gerrit-PatchSet: 6
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Aug 2019 05:13:07 +0000
Gerrit-HasComments: No