You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2020/03/07 15:08:12 UTC
[GitHub] [submarine] jasoonn opened a new pull request #206: SUBMARINE-397.
[WEB]Implement the job page in workbench with Angular
jasoonn opened a new pull request #206: SUBMARINE-397. [WEB]Implement the job page in workbench with Angular
URL: https://github.com/apache/submarine/pull/206
### What is this PR for?
Implement the job page in workbench with Angular.
### What type of PR is it?
[Feature]
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-397
### How should this be tested?
### Screenshots
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] jasoonn commented on issue #206: SUBMARINE-397.
[WEB]Implement the job page in workbench with Angular
Posted by GitBox <gi...@apache.org>.
jasoonn commented on issue #206: SUBMARINE-397. [WEB]Implement the job page in workbench with Angular
URL: https://github.com/apache/submarine/pull/206#issuecomment-596155911
@liuxunorg Thank for your advice. I have updated my pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on a change in pull request #206:
SUBMARINE-397. [WEB]Implement the job page in workbench with Angular
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on a change in pull request #206: SUBMARINE-397. [WEB]Implement the job page in workbench with Angular
URL: https://github.com/apache/submarine/pull/206#discussion_r389324993
##########
File path: submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/jobIT.java
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.submarine.integration;
+
+import org.apache.submarine.AbstractSubmarineIT;
+import org.apache.submarine.WebDriverManager;
+import org.apache.submarine.SubmarineITUtils;
+import org.openqa.selenium.By;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testng.annotations.AfterClass;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.Test;
+import org.testng.Assert;
+
+public class jobIT extends AbstractSubmarineIT {
+
+ public final static Logger LOG = LoggerFactory.getLogger(sidebarIT.class);
Review comment:
Need change to `public final static Logger LOG = LoggerFactory.getLogger(jobIT.class);`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] jasoonn commented on issue #206: SUBMARINE-397.
[WEB]Implement the job page in workbench with Angular
Posted by GitBox <gi...@apache.org>.
jasoonn commented on issue #206: SUBMARINE-397. [WEB]Implement the job page in workbench with Angular
URL: https://github.com/apache/submarine/pull/206#issuecomment-596097947
@kevin85421 @liuxunorg Can you help me review the pull request? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #206: SUBMARINE-397.
[WEB]Implement the job page in workbench with Angular
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #206: SUBMARINE-397. [WEB]Implement the job page in workbench with Angular
URL: https://github.com/apache/submarine/pull/206
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on issue #206: SUBMARINE-397.
[WEB]Implement the job page in workbench with Angular
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #206: SUBMARINE-397. [WEB]Implement the job page in workbench with Angular
URL: https://github.com/apache/submarine/pull/206#issuecomment-596101488
@jasoonn Thank you contribution for this feature.
Because `submarine-test/e2e` has been changed to `submarine-test/test-e2e`, you need to execute the following rebase command:
```
git checkout master
git pull
git checkout SUBMARINE-397
git rebase upstream/master
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on issue #206: SUBMARINE-397.
[WEB]Implement the job page in workbench with Angular
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #206: SUBMARINE-397. [WEB]Implement the job page in workbench with Angular
URL: https://github.com/apache/submarine/pull/206#issuecomment-596186124
Will merge if no more comments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org