You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/09/24 20:28:43 UTC
Review Request 38726: Make common attributes symmetrical to v1
attributes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38726/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
-------
This aids in verifying the files are kept in sync.
diff src/common/attributes.cpp src/v1/attributes.cpp should result
in only include and namespace differences.
Diffs
-----
src/common/attributes.cpp 8a8d6245135aff0a6cfde8dee46640770c38ed0d
Diff: https://reviews.apache.org/r/38726/diff/
Testing
-------
diff src/common/attributes.cpp src/v1/attributes.cpp
```
24,25c24,25
< #include <mesos/attributes.hpp>
< #include <mesos/values.hpp>
---
> #include <mesos/v1/attributes.hpp>
> #include <mesos/v1/values.hpp>
34d33
<
35a35
> namespace v1 {
227a228
> } // namespace v1 {
```
Thanks,
Joris Van Remoortere
Re: Review Request 38726: Make common attributes symmetrical to v1
attributes.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38726/#review100498
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Sept. 24, 2015, 6:30 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38726/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 6:30 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-3510
> https://issues.apache.org/jira/browse/MESOS-3510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This aids in verifying the files are kept in sync.
> diff src/common/attributes.cpp src/v1/attributes.cpp should result
> in only include and namespace differences.
>
>
> Diffs
> -----
>
> src/common/attributes.cpp 8a8d6245135aff0a6cfde8dee46640770c38ed0d
>
> Diff: https://reviews.apache.org/r/38726/diff/
>
>
> Testing
> -------
>
> diff src/common/attributes.cpp src/v1/attributes.cpp
> ```
> 24,25c24,25
> < #include <mesos/attributes.hpp>
> < #include <mesos/values.hpp>
> ---
> > #include <mesos/v1/attributes.hpp>
> > #include <mesos/v1/values.hpp>
> 34d33
> <
> 35a35
> > namespace v1 {
> 227a228
> > } // namespace v1 {
> ```
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 38726: Make common attributes symmetrical to v1
attributes.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38726/#review100480
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Sept. 24, 2015, 6:30 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38726/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 6:30 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-3510
> https://issues.apache.org/jira/browse/MESOS-3510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This aids in verifying the files are kept in sync.
> diff src/common/attributes.cpp src/v1/attributes.cpp should result
> in only include and namespace differences.
>
>
> Diffs
> -----
>
> src/common/attributes.cpp 8a8d6245135aff0a6cfde8dee46640770c38ed0d
>
> Diff: https://reviews.apache.org/r/38726/diff/
>
>
> Testing
> -------
>
> diff src/common/attributes.cpp src/v1/attributes.cpp
> ```
> 24,25c24,25
> < #include <mesos/attributes.hpp>
> < #include <mesos/values.hpp>
> ---
> > #include <mesos/v1/attributes.hpp>
> > #include <mesos/v1/values.hpp>
> 34d33
> <
> 35a35
> > namespace v1 {
> 227a228
> > } // namespace v1 {
> ```
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 38726: Make common attributes symmetrical to v1
attributes.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38726/
-----------------------------------------------------------
(Updated Sept. 24, 2015, 6:30 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-3510
https://issues.apache.org/jira/browse/MESOS-3510
Repository: mesos
Description
-------
This aids in verifying the files are kept in sync.
diff src/common/attributes.cpp src/v1/attributes.cpp should result
in only include and namespace differences.
Diffs
-----
src/common/attributes.cpp 8a8d6245135aff0a6cfde8dee46640770c38ed0d
Diff: https://reviews.apache.org/r/38726/diff/
Testing
-------
diff src/common/attributes.cpp src/v1/attributes.cpp
```
24,25c24,25
< #include <mesos/attributes.hpp>
< #include <mesos/values.hpp>
---
> #include <mesos/v1/attributes.hpp>
> #include <mesos/v1/values.hpp>
34d33
<
35a35
> namespace v1 {
227a228
> } // namespace v1 {
```
Thanks,
Joris Van Remoortere