You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@felix.apache.org by "Richard S. Hall (JIRA)" <ji...@apache.org> on 2009/07/30 05:14:14 UTC

[jira] Resolved: (FELIX-1277) Fix Service Hooks Tests failures in RFC 126 TCK

     [ https://issues.apache.org/jira/browse/FELIX-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall resolved FELIX-1277.
------------------------------------

    Resolution: Fixed

I committed this patch with modifications. I tried to simplify it by using references rather than registrations for the internal data structures and method parameters. This made sense since the service hooks are acquired like any normal service with a call to getService(). It also allowed me to eliminate the one comparator class, since reference already implements comparable. I also changed the maps holding hooks to sorted sets, since we weren't really using the value. I would like to investigate further simplifying these hooks, but I think it would take more changes to the service registry.

At any rate, it now passes the hooks test suite. Please close if you are satisfied. Thanks a lot!

> Fix Service Hooks Tests failures in RFC 126 TCK
> -----------------------------------------------
>
>                 Key: FELIX-1277
>                 URL: https://issues.apache.org/jira/browse/FELIX-1277
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: felix-1.8.1
>            Reporter: David Bosschaert
>            Assignee: Richard S. Hall
>             Fix For: felix-2.0.0
>
>         Attachments: rfc126_tck_fixes_3.patch
>
>
> 6 out of 7 of the TCK Service Hook Tests are failing. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.