You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2015/08/05 23:22:15 UTC
Review Request 37143: fix races in testRegionIdleInvalidate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37143/
-----------------------------------------------------------
Review request for geode and Kirk Lund.
Bugs: GEODE-185
https://issues.apache.org/jira/browse/GEODE-185
Repository: geode
Description
-------
The test code is now careful to wait for the expiration clock to advance.
A different assertion will be triggered if the expiration clock goes back in time.
Fixed two places in the product expiration code that did not use the expiration clock.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/ExpiryTask.java 95cd3a807ef54d66aaa9f257f6a3720738377a83
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionIdleExpiryTask.java fbcb12c8284e8f8829f48be5a18cecd48dc7d711
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 69eeec03016b98bb7b420e2d41e15e53053d43e8
gemfire-core/src/test/java/dunit/DistributedTestCase.java 564e7efb947e4dd77b8cb3fa40e1ac9491d75afa
Diff: https://reviews.apache.org/r/37143/diff/
Testing
-------
All RegionTestCase subclass dunits.
Thanks,
Darrel Schneider
Re: Review Request 37143: fix races in testRegionIdleInvalidate
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37143/#review94316
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On Aug. 5, 2015, 9:22 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37143/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 9:22 p.m.)
>
>
> Review request for geode and Kirk Lund.
>
>
> Bugs: GEODE-185
> https://issues.apache.org/jira/browse/GEODE-185
>
>
> Repository: geode
>
>
> Description
> -------
>
> The test code is now careful to wait for the expiration clock to advance.
> A different assertion will be triggered if the expiration clock goes back in time.
> Fixed two places in the product expiration code that did not use the expiration clock.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/ExpiryTask.java 95cd3a807ef54d66aaa9f257f6a3720738377a83
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionIdleExpiryTask.java fbcb12c8284e8f8829f48be5a18cecd48dc7d711
> gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 69eeec03016b98bb7b420e2d41e15e53053d43e8
> gemfire-core/src/test/java/dunit/DistributedTestCase.java 564e7efb947e4dd77b8cb3fa40e1ac9491d75afa
>
> Diff: https://reviews.apache.org/r/37143/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 37143: fix races in testRegionIdleInvalidate
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37143/
-----------------------------------------------------------
(Updated Aug. 5, 2015, 2:22 p.m.)
Review request for geode and Kirk Lund.
Bugs: GEODE-185
https://issues.apache.org/jira/browse/GEODE-185
Repository: geode
Description
-------
The test code is now careful to wait for the expiration clock to advance.
A different assertion will be triggered if the expiration clock goes back in time.
Fixed two places in the product expiration code that did not use the expiration clock.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/ExpiryTask.java 95cd3a807ef54d66aaa9f257f6a3720738377a83
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionIdleExpiryTask.java fbcb12c8284e8f8829f48be5a18cecd48dc7d711
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 69eeec03016b98bb7b420e2d41e15e53053d43e8
gemfire-core/src/test/java/dunit/DistributedTestCase.java 564e7efb947e4dd77b8cb3fa40e1ac9491d75afa
Diff: https://reviews.apache.org/r/37143/diff/
Testing (updated)
-------
precheckin
Thanks,
Darrel Schneider