You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@joshua.apache.org by michael-aloys <gi...@git.apache.org> on 2016/09/13 15:45:04 UTC
[GitHub] incubator-joshua pull request #52: Moved regression tests bn-en/hiero to uni...
GitHub user michael-aloys opened a pull request:
https://github.com/apache/incubator-joshua/pull/52
Moved regression tests bn-en/hiero to unit test
Moved the shell script regression tests from bn-en/hiero to a unit test class. Also cleaned up the corresponding resource directory. Regenerated gold output with "%c %s" format. Dropped test-filter.sh.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michael-aloys/incubator-joshua master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-joshua/pull/52.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #52
----
commit de364bd5ceac03f51557fcb88ee50b6fdb549ffe
Author: Michael A. Hedderich <mi...@users.noreply.github.com>
Date: 2016-09-13T15:32:31Z
Moved regression tests bn-en/hiero to unit test
Moved the shell script regression tests from bn-en/hiero to a unit test class. Also cleaned up the corresponding resource directory. Regenerated gold output with "%c %s" format. Dropped test-filter.sh.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua issue #52: Moved regression tests bn-en/hiero to unit test
Posted by mjpost <gi...@git.apache.org>.
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/52
Okay, on second thought, as we discussed, lets do these on master. Merging wasn't that difficult.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua pull request #52: Moved regression tests bn-en/hiero to uni...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-joshua/pull/52
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua issue #52: Moved regression tests bn-en/hiero to unit test
Posted by michael-aloys <gi...@git.apache.org>.
Github user michael-aloys commented on the issue:
https://github.com/apache/incubator-joshua/pull/52
If we do not remove the old tests from master, we need to coordinate in a different way on which tests are already moved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua issue #52: Moved regression tests bn-en/hiero to unit test
Posted by michael-aloys <gi...@git.apache.org>.
Github user michael-aloys commented on the issue:
https://github.com/apache/incubator-joshua/pull/52
Okay, I'll continue on 7.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua issue #52: Moved regression tests bn-en/hiero to unit test
Posted by mjpost <gi...@git.apache.org>.
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/52
Okay, this is merged in, obviously. But merging these back into 7 is turning into a pain. Since development is stopping on master, lets just do the rest of these on the 7 branch directly, okay?
@michael-aloys @KellenSunderland
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---