You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/29 01:00:19 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #15582: Add more typing to airflow.utils.helpers

uranusjr commented on a change in pull request #15582:
URL: https://github.com/apache/airflow/pull/15582#discussion_r622666746



##########
File path: airflow/utils/helpers.py
##########
@@ -31,10 +31,17 @@
 from airflow.exceptions import AirflowException
 from airflow.utils.module_loading import import_string
 
+if TYPE_CHECKING:
+    from airflow.models import TaskInstance
+
 KEY_REGEX = re.compile(r'^[\w.-]+$')
+CAMELCASE_TO_SNAKE_CASE_REGEX = re.compile('(?!^)([A-Z]+)')

Review comment:
       I’m surprised for all the opinions pylint have, it does not bother to enforce a regex pattern must always use an r-string.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org