[GitHub] imay closed pull request #521: Fix BE core if WHEN expr is null in CASE-WHEN clause

[GitBox <gi...@apache.org>]

imay closed pull request #521: Fix BE core if WHEN expr is null in CASE-WHEN clause
URL: https://github.com/apache/incubator-doris/pull/521
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/fe/src/main/java/org/apache/doris/analysis/CaseExpr.java b/fe/src/main/java/org/apache/doris/analysis/CaseExpr.java
index aae504e8..1d0f9f83 100644
--- a/fe/src/main/java/org/apache/doris/analysis/CaseExpr.java
+++ b/fe/src/main/java/org/apache/doris/analysis/CaseExpr.java
@@ -174,7 +174,7 @@ public void analyzeImpl(Analyzer analyzer) throws AnalysisException {
                             + " is not of type boolean and not castable to type boolean.");
                 }
                 // Add a cast if necessary.
-                if (whenExpr.getType().isBoolean()) {
+                if (!whenExpr.getType().isBoolean()) {
                     castChild(Type.BOOLEAN, i);
                 }
             }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org