You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/07 23:48:41 UTC
[GitHub] [incubator-superset] mistercrunch opened a new pull request #9255:
fix: change database save in DatasourceEditor
mistercrunch opened a new pull request #9255: fix: change database save in DatasourceEditor
URL: https://github.com/apache/incubator-superset/pull/9255
This addresses the issue where pointing a datasource to another database
in the datasource editor is not reflected.
Also addresses:
- a minor cosmetic issue in the datasource editor.
- user/owners list not getting populated
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull
request #9255: fix: change database save in DatasourceEditor
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #9255: fix: change database save in DatasourceEditor
URL: https://github.com/apache/incubator-superset/pull/9255#discussion_r390439817
##########
File path: tests/fixtures/datasource.py
##########
@@ -18,6 +18,7 @@
datasource_post = {
"id": None,
"column_formats": {"ratio": ".2%"},
+ "database": {"id": 1},
Review comment:
Yes, actually here I replace it in the test itself. Not sure what the proper approach here, a function that receives an object and returns a fixture? I'm guessing with DAO abstraction we can get more creative on generating proper fixtures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9255: fix:
change database save in DatasourceEditor
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9255: fix: change database save in DatasourceEditor
URL: https://github.com/apache/incubator-superset/pull/9255#issuecomment-596229843
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9255?src=pr&el=h1) Report
> Merging [#9255](https://codecov.io/gh/apache/incubator-superset/pull/9255?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/89109a16c68919d9c1688d0777351125adec9210?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9255 +/- ##
=======================================
Coverage 58.92% 58.92%
=======================================
Files 373 373
Lines 12016 12016
Branches 2948 2948
=======================================
Hits 7081 7081
Misses 4756 4756
Partials 179 179
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9255?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9255/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `61.25% <ø> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9255?src=pr&el=footer). Last update [89109a1...c125195](https://codecov.io/gh/apache/incubator-superset/pull/9255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on a change in pull
request #9255: fix: change database save in DatasourceEditor
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #9255: fix: change database save in DatasourceEditor
URL: https://github.com/apache/incubator-superset/pull/9255#discussion_r389803011
##########
File path: superset/views/core.py
##########
@@ -745,6 +745,7 @@ def import_dashboards(self):
try:
dashboard_import_export.import_dashboards(db.session, f.stream)
except DatabaseNotFound as e:
+ logger.exception(e)
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on a change in pull
request #9255: fix: change database save in DatasourceEditor
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #9255: fix: change database save in DatasourceEditor
URL: https://github.com/apache/incubator-superset/pull/9255#discussion_r389803384
##########
File path: tests/base_tests.py
##########
@@ -268,7 +268,7 @@ def create_fake_db(self):
cls=models.Database,
criteria={"database_name": database_name},
session=db.session,
- sqlalchemy_uri="sqlite://test",
+ sqlalchemy_uri="sqlite:///:memory:",
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on a change in pull
request #9255: fix: change database save in DatasourceEditor
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #9255: fix: change database save in DatasourceEditor
URL: https://github.com/apache/incubator-superset/pull/9255#discussion_r389804938
##########
File path: tests/fixtures/datasource.py
##########
@@ -18,6 +18,7 @@
datasource_post = {
"id": None,
"column_formats": {"ratio": ".2%"},
+ "database": {"id": 1},
Review comment:
Eventually it would be good to move these to randomly generated IDs (note to self)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #9255: fix:
change database save in DatasourceEditor
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #9255: fix: change database save in DatasourceEditor
URL: https://github.com/apache/incubator-superset/pull/9255
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org