[jira] Updated: (SHINDIG-1399) Improved extensibility for PHP Shindig

["Bastian Hofmann (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SHINDIG-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bastian Hofmann updated SHINDIG-1399:
-------------------------------------

    Attachment: dependency_injection.patch

> Improved extensibility for PHP Shindig
> --------------------------------------
>
>                 Key: SHINDIG-1399
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1399
>             Project: Shindig
>          Issue Type: Improvement
>          Components: PHP
>            Reporter: Bastian Hofmann
>         Attachments: dependency_injection.patch
>
>
> This patch improves the extensibility with container specific implementation in PHP shindig by:
> - making several classes better overrideable by making former private methods and members protected
> - using dependency injection for Gadget, GadgetContext, GadgetFactory, GadgetSpecParser, GadgetSpec, Substitutions and ProxyHandler
> - providing the current GadgetContext in GadgetSpecParser
> Additionally TemplateLibraries can now be loaded with relative path as well (like the messagebundles). So that we don't have copied logic here, I moved the code to determine the absolute url out of the relative one out of the GadgetFactory into RemoteContentRequest class. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.