You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2002/05/03 06:45:46 UTC
cvs commit: jakarta-tomcat-4.0/webapps/admin/users user.jsp
manveen 02/05/02 21:45:46
Modified: webapps/admin/users user.jsp
Log:
* Password should not be displayed in clear text.
* Add URLs to create and delete users.
Revision Changes Path
1.3 +10 -9 jakarta-tomcat-4.0/webapps/admin/users/user.jsp
Index: user.jsp
===================================================================
RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/users/user.jsp,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- user.jsp 10 Feb 2002 08:06:20 -0000 1.2
+++ user.jsp 3 May 2002 04:45:46 -0000 1.3
@@ -38,16 +38,17 @@
<controls:action>
---------------------------------
</controls:action>
- <!-- will add the urls later once those screens get implemented -->
-<%--
- <controls:action url="">
- <bean:message key="users.actions.user.create"/>
+ <controls:action url='<%= "/users/setUpUser.do?databaseName=" +
+ URLEncoder.encode(request.getParameter("databaseName")) %>'>
+ <bean:message key="users.actions.user.create"/>
</controls:action>
- <controls:action url="">
- <bean:message key="users.actions.user.delete"/>
+
+ <controls:action url='<%= "/users/listUsers.do?databaseName=" +
+ URLEncoder.encode(request.getParameter("databaseName")) +
+ "&forward=" + URLEncoder.encode("Users Delete List") %>'>
+ <bean:message key="users.actions.user.delete"/>
</controls:action>
---%>
- </controls:actions>
+ </controls:actions>
</div>
</td>
</tr>
@@ -95,7 +96,7 @@
<bean:message key="users.prompt.password"/>
</controls:label>
<controls:data>
- <html:text property="password" size="24" maxlength="32"/>
+ <html:password property="password" size="24" maxlength="32"/>
</controls:data>
</controls:row>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-tomcat-4.0/webapps/admin/users user.jsp
Posted by Bill Barker <wb...@wilshire.com>.
----- Original Message -----
From: <ma...@apache.org>
To: <ja...@apache.org>
Sent: Thursday, May 02, 2002 9:45 PM
Subject: cvs commit: jakarta-tomcat-4.0/webapps/admin/users user.jsp
> manveen 02/05/02 21:45:46
>
> Modified: webapps/admin/users user.jsp
> Log:
> * Password should not be displayed in clear text.
Since the Password is only obscured on the client's browser, without a
"confirm password" box, this really doesn't make the app more secure. But
it does make it more error prone to random typos.
Just my opinion, since I'm not actively involved with coding.
N.B. I really like the new look of the Manager. Greate job!
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>