You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Oliver Frost (Jira)" <ji...@apache.org> on 2019/11/21 13:56:00 UTC

[jira] [Created] (AIRFLOW-6031) Check for additional sleep time in LocalTaskJob is flawed

Oliver Frost created AIRFLOW-6031:
-------------------------------------

             Summary: Check for additional sleep time in LocalTaskJob is flawed
                 Key: AIRFLOW-6031
                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6031
             Project: Apache Airflow
          Issue Type: Bug
          Components: worker
    Affects Versions: 1.10.6
            Reporter: Oliver Frost


Since the PR for issue AIRFLOW-5102 the implementation of the heartbeat is such that the check for additional sleep time in the LocalTaskJob always triggers, because it uses the time _after_ the heartbeat's sleep as reference.

Hence a warning like 
{noformat}
{local_task_job.py:124} WARNING - Time since last heartbeat(0.01 s) < heartrate(10.0 s), sleeping for 9.9881 s
{noformat}
 
Others already noticed and reported that the warning issued on that code path was flooding their logging systems in AIRFLOW-5690.

Sadly the pull request associated with AIRFLOW-5690 only silences the warning instead of realizing that the implementation logic is actually amiss.

The check for additional sleep time should be reverted to the logic before the PR related to AIRFLOW-5102, while keeping the self termination route intact.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)