You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Alan Wood <Al...@clear.net.nz> on 2011/04/02 05:54:05 UTC
[PATCH] unlock_cache called twice
Hi All,
Attached is a patch to fix a lock-up in the test_cache.exe on my windows system.
[[[
Fix the releasing of an already released mutex that caused test_cache to lock up when
attempting to the aquire the mutex a second time.
* subversion/libsvn_subr/cache-inprocess.c
(inprocess_cache_get): remove second unlock of cache
]]]
Alan
Re: [PATCH] unlock_cache called twice
Posted by Stefan Fuhrmann <eq...@web.de>.
On 02.04.2011 07:52, Alan Wood wrote:
> Strange, it was a .txt file as an attachment but here it is inline too.
> Created the patch with Tsvn seems it got a mix of lin endings in it. I wonder if that didn't help.
> This time with all txt line endings.
In my private mailbox, the attachment was there
even for your initial post ...
>
> Hi All,
> Attached is a patch to fix a lock-up in the test_cache.exe on my windows system.
>
> [[[
> Fix the releasing of an already released mutex that caused test_cache to lock up when
> attempting to the aquire the mutex a second time.
>
> * subversion/libsvn_subr/cache-inprocess.c
> (inprocess_cache_get): remove second unlock of cache
> ]]]
>
>
> Alan
>
> Index: subversion/libsvn_subr/cache-inprocess.c
> ===================================================================
> --- subversion/libsvn_subr/cache-inprocess.c (revision 1087960)
> +++ subversion/libsvn_subr/cache-inprocess.c (working copy)
> @@ -248,7 +248,7 @@
> else
> *value_p = NULL;
>
> - return unlock_cache(cache, err);
> + return err;
> }
>
> /* Removes PAGE from the LRU list, removes all of its entries from
Thanks a lot! Committed as r1088341.
-- Stefan^2.
P.S.: Greetings from Stuttgart to New Zealand!
I really missed the summer sun this winter.
Re: [PATCH] unlock_cache called twice
Posted by Alan Wood <Al...@clear.net.nz>.
Strange, it was a .txt file as an attachment but here it is inline too.
Created the patch with Tsvn seems it got a mix of lin endings in it. I wonder if that didn't help.
This time with all txt line endings.
Hi All,
Attached is a patch to fix a lock-up in the test_cache.exe on my windows system.
[[[
Fix the releasing of an already released mutex that caused test_cache to lock up when
attempting to the aquire the mutex a second time.
* subversion/libsvn_subr/cache-inprocess.c
(inprocess_cache_get): remove second unlock of cache
]]]
Alan
Index: subversion/libsvn_subr/cache-inprocess.c
===================================================================
--- subversion/libsvn_subr/cache-inprocess.c (revision 1087960)
+++ subversion/libsvn_subr/cache-inprocess.c (working copy)
@@ -248,7 +248,7 @@
else
*value_p = NULL;
- return unlock_cache(cache, err);
+ return err;
}
/* Removes PAGE from the LRU list, removes all of its entries from
Re: [PATCH] unlock_cache called twice
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
The patch didn't reach the list.
(try attaching it as *.txt)
Alan Wood wrote on Sat, Apr 02, 2011 at 16:54:05 +1300:
> Hi All,
> Attached is a patch to fix a lock-up in the test_cache.exe on my windows system.
>
> [[[
> Fix the releasing of an already released mutex that caused test_cache to lock up when
> attempting to the aquire the mutex a second time.
>
> * subversion/libsvn_subr/cache-inprocess.c
> (inprocess_cache_get): remove second unlock of cache
> ]]]
>
>
> Alan