You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/10 03:22:38 UTC
[GitHub] [incubator-nuttx-website] btashton opened a new pull request #21:
Only publish site on push to master. Build for all PR
btashton opened a new pull request #21: Only publish site on push to master. Build for all PR
URL: https://github.com/apache/incubator-nuttx-website/pull/21
This resolves an issue where the GitHub action could not perform the push action against the repository. Now the site is built for all pull requests, but only is published on the push to the master branch. Note that the push to master event happens when the pull request is merged.
This restriction is because you do not want the PR context to be able to have write access to the repository as outlined here:
https://help.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token#permissions-for-the-github_token
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-website] xiaoxiang781216 merged pull request #21:
Only publish site on push to master. Build for all PR
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #21: Only publish site on push to master. Build for all PR
URL: https://github.com/apache/incubator-nuttx-website/pull/21
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-website] btashton commented on issue #21: Only
publish site on push to master. Build for all PR
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #21: Only publish site on push to master. Build for all PR
URL: https://github.com/apache/incubator-nuttx-website/pull/21#issuecomment-611886467
It did. You can see it on the commit in master
https://github.com/apache/incubator-nuttx-website/runs/576061018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-website] xiaoxiang781216 commented on issue #21:
Only publish site on push to master. Build for all PR
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #21: Only publish site on push to master. Build for all PR
URL: https://github.com/apache/incubator-nuttx-website/pull/21#issuecomment-611888094
Yes, I saw the resut. Great!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-website] xiaoxiang781216 commented on issue #21:
Only publish site on push to master. Build for all PR
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #21: Only publish site on push to master. Build for all PR
URL: https://github.com/apache/incubator-nuttx-website/pull/21#issuecomment-611886075
@btashton Why I don't see the build auto start?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services