You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by ba...@apache.org on 2006/01/14 19:45:45 UTC
svn commit: r369077 -
/myfaces/api/trunk/api/src/main/java/javax/faces/webapp/UIComponentTag.java
Author: baranda
Date: Sat Jan 14 10:45:40 2006
New Revision: 369077
URL: http://svn.apache.org/viewcvs?rev=369077&view=rev
Log:
Applied patch for MYFACES-1029. Thanks to Dennis Byrne
Modified:
myfaces/api/trunk/api/src/main/java/javax/faces/webapp/UIComponentTag.java
Modified: myfaces/api/trunk/api/src/main/java/javax/faces/webapp/UIComponentTag.java
URL: http://svn.apache.org/viewcvs/myfaces/api/trunk/api/src/main/java/javax/faces/webapp/UIComponentTag.java?rev=369077&r1=369076&r2=369077&view=diff
==============================================================================
--- myfaces/api/trunk/api/src/main/java/javax/faces/webapp/UIComponentTag.java (original)
+++ myfaces/api/trunk/api/src/main/java/javax/faces/webapp/UIComponentTag.java Sat Jan 14 10:45:40 2006
@@ -547,6 +547,16 @@
{
//Child
String id = getOrCreateUniqueId(context);
+
+ // Warn users that this tag is about to find/steal the UIComponent
+ // that has already been created for a sibling tag with the same id value .
+ // _childrenAdded is a Set, and we will stomp over a past id when calling
+ // addChildIdToParentTag.
+ if(parentTag._childrenAdded != null && parentTag._childrenAdded.contains(id))
+ {
+ log.warn("There is more than one JSF tag with an id of " + id);
+ }
+
_componentInstance = findComponent(parent,id);
if (_componentInstance == null)
{