You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2015/03/16 14:12:38 UTC

[jira] [Commented] (LENS-410) Fix usage of Hive.get() in code

    [ https://issues.apache.org/jira/browse/LENS-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363171#comment-14363171 ] 

Hudson commented on LENS-410:
-----------------------------

SUCCESS: Integrated in Lens-Commit #643 (See [https://builds.apache.org/job/Lens-Commit/643/])
LENS-410 : Fix usage Hive.get() in code (amareshwari) (amareshwari: rev 9d9a204056484e159ee677962c8cc79fa12bc859)
* lens-server/src/main/java/org/apache/lens/server/stats/store/log/LogStatisticsStore.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java
* lens-server/src/main/java/org/apache/lens/server/stats/event/LoggableLensStatistics.java
* lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
* lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogPartitionHandler.java
* lens-server/src/main/java/org/apache/lens/server/stats/event/query/QueryExecutionStatistics.java
* lens-server/src/test/java/org/apache/lens/server/stats/TestLogStatisticsStore.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java
* lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java
* lens-server/src/main/java/org/apache/lens/server/stats/store/StatisticsStore.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java


> Fix usage of Hive.get() in code
> -------------------------------
>
>                 Key: LENS-410
>                 URL: https://issues.apache.org/jira/browse/LENS-410
>             Project: Apache Lens
>          Issue Type: Improvement
>          Components: cube, server
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 2.1
>
>         Attachments: LENS-410.1.patch
>
>
> The following occurrence of Hive.get() should be fixed - to use cube client or proper configuration object.
> {noformat}
> lens-cube amareshwari.sr$ git grep 'Hive.get(' src/main/java/
> src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java:    return Hive.get(config);
> src/main/java/org/apache/lens/cube/parse/CandidateFact.java:      partitionKeys = Hive.get().getTable(singleStorageTable).getPartitionKeys();
> lens-driver-hive amareshwari.sr$ git grep 'Hive.get(' src/main/java/
> src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java:    Hive metastore = Hive.get(metastoreConf);
> lens-server amareshwari.sr$ git grep 'Hive.get(' src/main/java/
> src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java:      if (!Hive.get(getSession(sessionid).getHiveConf()).databaseExists(database)) {
> src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java:      Hive.get(getSession(sessionid).getHiveConf()).dropDatabase(database, false, true, cascade);
> src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java:      Hive.get(getSession(sessionid).getHiveConf()).createDatabase(db, ignore);
> src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java:      return Hive.get(getSession(sessionid).getHiveConf()).getAllDatabases();
> src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java:        if (!Hive.get().databaseExists(dbName)) {
> src/main/java/org/apache/lens/server/session/HiveSessionService.java:        if (!Hive.get(getSession(sessionid).getHiveConf()).databaseExists(database)) {
> src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java:      client = Hive.get();
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)