You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by gc...@apache.org on 2010/01/07 02:21:31 UTC

svn commit: r896728 - /myfaces/trinidad/branches/trinidad-2.0.x/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/ChildArrayList.java

Author: gcrawford
Date: Thu Jan  7 01:21:31 2010
New Revision: 896728

URL: http://svn.apache.org/viewvc?rev=896728&view=rev
Log:
TRINIDAD-1674 Trinidad 2 - New NPE when adding component programatically


Modified:
    myfaces/trinidad/branches/trinidad-2.0.x/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/ChildArrayList.java

Modified: myfaces/trinidad/branches/trinidad-2.0.x/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/ChildArrayList.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/branches/trinidad-2.0.x/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/ChildArrayList.java?rev=896728&r1=896727&r2=896728&view=diff
==============================================================================
--- myfaces/trinidad/branches/trinidad-2.0.x/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/ChildArrayList.java (original)
+++ myfaces/trinidad/branches/trinidad-2.0.x/trinidad-api/src/main/java/org/apache/myfaces/trinidad/component/ChildArrayList.java Thu Jan  7 01:21:31 2010
@@ -57,9 +57,10 @@
         index = adjustedIndex; 
       }
     }
-
-    element.setParent(_parent);
+    
+    // do not change the order of these calls, see TRINIDAD-1674 for more info
     super.add(index, element);
+    element.setParent(_parent);
   }