You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by ilooner <gi...@git.apache.org> on 2018/04/17 18:59:05 UTC

[GitHub] drill pull request #1215: DRILL-6338: Do not skip license maven plugin when ...

GitHub user ilooner opened a pull request:

    https://github.com/apache/drill/pull/1215

    DRILL-6338: Do not skip license maven plugin when formatting generate…

    …d protobuf files.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ilooner/drill DRILL-6338

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1215
    
----
commit 64d5bece38275375d5e2f24a64dd0643a5d92964
Author: Timothy Farkas <ti...@...>
Date:   2018-04-17T18:57:40Z

    DRILL-6338: Do not skip license maven plugin when formatting generated protobuf files.

----


---

[GitHub] drill pull request #1215: DRILL-6338: Do not skip license maven plugin when ...

Posted by ilooner <gi...@git.apache.org>.

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1215#discussion_r182266896
  
    --- Diff: protocol/pom.xml ---
    @@ -149,8 +152,12 @@
               <plugin>
                 <groupId>com.mycila</groupId>
                 <artifactId>license-maven-plugin</artifactId>
    +            <configuration>
    --- End diff --
    
    Thanks for catching. Removed, verified that `mvn process-sources -P proto-compile` and `mvn clean install -P proto-compile` generated code with the headers and that `mvn process-sources -P proto-compile -Dlicense.skip=true` generates sources without license headers.


---

[GitHub] drill issue #1215: DRILL-6338: Do not skip license maven plugin when formatt...

Posted by ilooner <gi...@git.apache.org>.

Github user ilooner commented on the issue:

    https://github.com/apache/drill/pull/1215
  
    @vrozov @arina-ielchiieva Please review.


---

[GitHub] drill issue #1215: DRILL-6338: Do not skip license maven plugin when formatt...

Posted by arina-ielchiieva <gi...@git.apache.org>.

Github user arina-ielchiieva commented on the issue:

    https://github.com/apache/drill/pull/1215
  
    LGTM.


---

[GitHub] drill pull request #1215: DRILL-6338: Do not skip license maven plugin when ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/1215


---

[GitHub] drill pull request #1215: DRILL-6338: Do not skip license maven plugin when ...

Posted by vrozov <gi...@git.apache.org>.

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1215#discussion_r182259451
  
    --- Diff: protocol/pom.xml ---
    @@ -149,8 +152,12 @@
               <plugin>
                 <groupId>com.mycila</groupId>
                 <artifactId>license-maven-plugin</artifactId>
    +            <configuration>
    --- End diff --
    
    Do no force `<skip>`. It should be already `false`.


---