You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/13 07:24:00 UTC
[jira] [Commented] (AIRFLOW-3689) Update pop-up messages for
feature "Keeps records in Log Table when delete DAG"
[ https://issues.apache.org/jira/browse/AIRFLOW-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741482#comment-16741482 ]
ASF GitHub Bot commented on AIRFLOW-3689:
-----------------------------------------
XD-DENG commented on pull request #4505: [AIRFLOW-3689] Update pop-up messages for feature 'Keeps records in Log Table when delete DAG'
URL: https://github.com/apache/airflow/pull/4505
### Jira
- https://issues.apache.org/jira/browse/AIRFLOW-3689
### Description
The original feature was added in https://github.com/apache/airflow/pull/4287,
but the pop-up messages was only updated in airflow/www/templates/airflow/dag.html,
while it should be updated for all dag.html & dags.html for both /www and /www_rbac.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Update pop-up messages for feature "Keeps records in Log Table when delete DAG"
> -------------------------------------------------------------------------------
>
> Key: AIRFLOW-3689
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3689
> Project: Apache Airflow
> Issue Type: Improvement
> Components: api
> Reporter: Xiaodong DENG
> Assignee: Xiaodong DENG
> Priority: Minor
>
> In PR [https://github.com/apache/airflow/pull/4287,] I developed the feature "keeps records in Log Table when delete DAG". The pop-up message that appear when user tries to delete a DAG should also be updated, in order to remind users that records in "log" table will not be removed.
> This should be updated in
> - [airflow/www/templates/airflow/dag.html|https://github.com/apache/airflow/pull/4287/files#diff-9f17202cd46d5c42ef03c2406ba80fd9]
> - [airflow/www/templates/airflow/dags.html|https://github.com/apache/airflow/pull/4287/files#diff-9f17202cd46d5c42ef03c2406ba80fd9]
> - [airflow/www_rbac/templates/airflow/dag.html|https://github.com/apache/airflow/pull/4287/files#diff-9f17202cd46d5c42ef03c2406ba80fd9]
> - [airflow/www_rbac/templates/airflow/dags.html|https://github.com/apache/airflow/pull/4287/files#diff-9f17202cd46d5c42ef03c2406ba80fd9]
>
> But only the first one was updated. This should be followed up.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)