You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/06/14 18:05:27 UTC
[GitHub] [commons-text] fykidwai opened a new pull request #239: Remove use of restricted identifier
fykidwai opened a new pull request #239:
URL: https://github.com/apache/commons-text/pull/239
Modified variable name from 'var' to 'key' to avoid confusion in future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-text] XenoAmess commented on pull request #239: Remove use of restricted identifier
Posted by GitBox <gi...@apache.org>.
XenoAmess commented on pull request #239:
URL: https://github.com/apache/commons-text/pull/239#issuecomment-860886113
lgtm.
var have some other meanings in 11+ so change it is a good point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-text] kinow commented on pull request #239: Remove use of restricted identifier
Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #239:
URL: https://github.com/apache/commons-text/pull/239#issuecomment-861197293
Harmless changes, cosmetic only. LGTM, no need for a JIRA issue. Thanks @fykidwai !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-text] kinow merged pull request #239: Remove use of restricted identifier
Posted by GitBox <gi...@apache.org>.
kinow merged pull request #239:
URL: https://github.com/apache/commons-text/pull/239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-text] XenoAmess edited a comment on pull request #239: Remove use of restricted identifier
Posted by GitBox <gi...@apache.org>.
XenoAmess edited a comment on pull request #239:
URL: https://github.com/apache/commons-text/pull/239#issuecomment-860886113
lgtm.
`var` have some other meanings in 11+ so change it is a good point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org