[jira] [Created] (HDFS-16710) Remove redundant throw exceptions in org.apahce.hadoop.hdfs.server.namenode package

["ZanderXu (Jira)" <ji...@apache.org>]

ZanderXu created HDFS-16710:
-------------------------------

             Summary: Remove redundant throw exceptions in org.apahce.hadoop.hdfs.server.namenode package
                 Key: HDFS-16710
                 URL: https://issues.apache.org/jira/browse/HDFS-16710
             Project: Hadoop HDFS
          Issue Type: Improvement
            Reporter: ZanderXu
            Assignee: ZanderXu


When I read some class about HDFS NameNode, I found there are many redundant throw exception in org.apahce.hadoop.hdfs.server.namenode package, such as:

 
{code:java}
public synchronized void transitionToObserver(StateChangeRequestInfo req)
    throws ServiceFailedException, AccessControlException, IOException {
  checkNNStartup();
  nn.checkHaStateChange(req);
  nn.transitionToObserver();
} {code}
Because ServiceFailedException and AccessControlException is subClass of IOException, so I feel that ServiceFailedException and AccessControlException are redundant, so we can remove it to make code clearer, such as:

 

 
{code:java}
public synchronized void transitionToObserver(StateChangeRequestInfo req)
    throws IOException {
  checkNNStartup();
  nn.checkHaStateChange(req);
  nn.transitionToObserver();
} {code}
 

 

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org