You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/14 07:40:34 UTC

[GitHub] [apisix] kingluo opened a new issue, #8519: bug: grpc-transcode do not close core.config instance when the plugin is unloaded

kingluo opened a new issue, #8519:
URL: https://github.com/apache/apisix/issues/8519

   ### Current Behavior
   
   https://github.com/apache/apisix/blob/5f071049777facc1bc0b690ede3928f9da6b49c5/apisix/plugins/grpc-transcode.lua#L121
   
   https://github.com/apache/apisix/blob/5f071049777facc1bc0b690ede3928f9da6b49c5/apisix/plugins/grpc-transcode/proto.lua#L253-L256
   
   This plugin does not define `destroy()`.
   
   config instance of etcd would create a timer to refresh `"/protos"` resource. We need to close the instance in `destroy()`, which in turn closes the timer.
   
   
   ### Expected Behavior
   
   _No response_
   
   ### Error Logs
   
   _No response_
   
   ### Steps to Reproduce
   
   ```bash 
   curl http://127.0.0.1:9180/apisix/admin/plugins/reload -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT
   ```
   
   ### Environment
   
   - APISIX version (run `apisix version`): master branch
   - Operating system (run `uname -a`):
   - OpenResty / Nginx version (run `openresty -V` or `nginx -V`):
   - etcd version, if relevant (run `curl http://127.0.0.1:9090/v1/server_info`):
   - APISIX Dashboard version, if relevant:
   - Plugin runner version, for issues related to plugin runners:
   - LuaRocks version, for installation issues (run `luarocks --version`):
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander closed issue #8519: bug: grpc-transcode do not close core.config instance when the plugin is unloaded

Posted by GitBox <gi...@apache.org>.
spacewander closed issue #8519: bug: grpc-transcode do not close core.config instance when the plugin is unloaded
URL: https://github.com/apache/apisix/issues/8519


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org