[jira] [Work logged] (CSV-304) Provide access methods for header and trailer comments

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CSV-304?focusedWorklogId=806401&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806401 ]

ASF GitHub Bot logged work on CSV-304:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Sep/22 14:31
            Start Date: 06/Sep/22 14:31
    Worklog Time Spent: 10m 
      Work Description: pedro-w opened a new pull request, #257:
URL: https://github.com/apache/commons-csv/pull/257

   Add accessors for header comments (before the header row)
   and trailer comments (after the last record)
   Also add javadoc and tests
   
   See https://issues.apache.org/jira/browse/CSV-304




Issue Time Tracking
-------------------

            Worklog Id:     (was: 806401)
    Remaining Estimate: 0h
            Time Spent: 10m

> Provide access methods for header and trailer comments
> ------------------------------------------------------
>
>                 Key: CSV-304
>                 URL: https://issues.apache.org/jira/browse/CSV-304
>             Project: Commons CSV
>          Issue Type: Improvement
>          Components: Parser
>    Affects Versions: 1.9.0
>            Reporter: Peter Hull
>            Priority: Minor
>             Fix For: Discussion
>
>         Attachments: header-comment.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The Apache Commons CSV library can deal with comments by attaching the comment to the following record.
> It does not seem possible to access comments that are before the header line ("header comments"), or after the last record ("trailer comments")
> I feel this would be a useful enhancement to the current comment-handling features of version 1.9.
> I have not been able to find mention of this in other JIRA tickets.
> I have attached a patch implementing this, for discussion purposes. (n.b. I had trouble with git showing spurious ^M at the end of changed lines in CSVParserTest.java which I could not get rid of)
> This adds methods String CSVParser::getHeaderComment(), String CSVParser::getTrailerComment(), bool CSVParser::hasHeaderComment() and bool CSVParser::hasTrailerComment() . The last two could be omitted assuming a missing comment would return a null String.
>  
> See also [https://stackoverflow.com/questions/72619095/get-leading-comments-from-csv-with-apache-commons-csv] and [https://lists.apache.org/thread/8tczpqlnjgbcyovyhb484tt11vqv91jt]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)