You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Melissa Pashniak (JIRA)" <ji...@apache.org> on 2019/01/08 22:11:00 UTC

[jira] [Commented] (BEAM-3643) Remove documentation for creating custom sinks

    [ https://issues.apache.org/jira/browse/BEAM-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737586#comment-16737586 ] 

Melissa Pashniak commented on BEAM-3643:
----------------------------------------

The doc page has been updated to not use plain Sink in PR 7397, it now recommends using a ParDo, or a FileBasedSink specifically. Removal of snippets still needs to be done.

 

> Remove documentation for creating custom sinks
> ----------------------------------------------
>
>                 Key: BEAM-3643
>                 URL: https://issues.apache.org/jira/browse/BEAM-3643
>             Project: Beam
>          Issue Type: Bug
>          Components: website
>            Reporter: Udi Meiri
>            Assignee: Melissa Pashniak
>            Priority: Minor
>
> I believe this whole section should be removed:
> [https://beam.apache.org/documentation/sdks/python-custom-io/#creating-a-new-sink]
> The reason is that class Sink is deprecated:
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/iobase.py#L578]
> Associated code snippets should also be removed:
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/examples/snippets/snippets.py#L782]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)