You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/06/20 15:23:51 UTC
[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #966: HDDS-1686. Remove check to get from openKeyTable in acl implementatio…
bharatviswa504 commented on a change in pull request #966: HDDS-1686. Remove check to get from openKeyTable in acl implementatio…
URL: https://github.com/apache/hadoop/pull/966#discussion_r295861790
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##########
@@ -1370,17 +1370,10 @@ public boolean addAcl(OzoneObj obj, OzoneAcl acl) throws IOException {
validateBucket(volume, bucket);
String objectKey = metadataManager.getOzoneKey(volume, bucket, keyName);
OmKeyInfo keyInfo = metadataManager.getKeyTable().get(objectKey);
- Table keyTable;
if (keyInfo == null) {
Review comment:
Sure we can do that? What is the use case for setting acl for an openKey which is not committed to OM. Just want to understand the reason behind it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org