[GitHub] [dolphinscheduler] lenboo commented on a diff in pull request #11204: [Fix-11197] [Master] Dependency detection bug

[GitBox <gi...@apache.org>]

lenboo commented on code in PR #11204:
URL: https://github.com/apache/dolphinscheduler/pull/11204#discussion_r952133064


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java:
##########
@@ -129,51 +140,87 @@ private DependResult calculateResultForTasks(DependentItem dependentItem,
 
     /**
      * depend type = depend_all
-     *
-     * @return
      */
-    private DependResult dependResultByProcessInstance(ProcessInstance processInstance) {
-        if (!processInstance.getState().isFinished()) {
-            return DependResult.WAITING;
-        }
+    private DependResult dependResultByProcessInstance(ProcessInstance processInstance, DateInterval dateInterval) {
         if (processInstance.getState().isSuccess()) {
+            List<ProcessTaskRelation> taskRelations = processService.findRelationByCode(processInstance.getProcessDefinitionCode(),

Review Comment:
   The workflow dependent only need check the process instance state.
   There are scenarios in which only some tasks are run, resulting in a successful workflow.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org