You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by hogniRunar <gi...@git.apache.org> on 2016/03/30 13:21:08 UTC
[GitHub] cloudstack pull request: writeIfNotHere requires an array of strin...
GitHub user hogniRunar opened a pull request:
https://github.com/apache/cloudstack/pull/1456
writeIfNotHere requires an array of strings, not a string
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greenqloud/cloudstack pr-4.7-baremetal_metadata_parameter_bugfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1456.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1456
----
commit fde0b6aa579c0604f794713e5d8a83b242ea2c4e
Author: Högni Ingimarsson <ho...@greenqloud.com>
Date: 2016-03-30T10:39:22Z
writeIfNotHere requires an array of strings, not a string
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: writeIfNotHere requires an array of strin...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1456#issuecomment-218847217
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: writeIfNotHere requires an array of strin...
Posted by hogniRunar <gi...@git.apache.org>.
Github user hogniRunar commented on the pull request:
https://github.com/apache/cloudstack/pull/1456#issuecomment-203448721
To reproduce it you just need to set up a basic baremetal zone, start an instance and on the bootserver for baremetal you can look at /var/www/html/metadata/<IP of instance>/meta-data. As for testing I am not sure what would be the best way other than looking at that same file once the fix has been implemented.
Ticket:
https://issues.apache.org/jira/browse/CLOUDSTACK-9330
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: writeIfNotHere requires an array of strin...
Posted by pdube <gi...@git.apache.org>.
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1456#issuecomment-203437320
Hi @hogniRunar,
The code change LGTM. I verified for references to the function, but did not test it. Could you create a JIRA ticket for it please? Could you also add some information as to how do you reproduce the error, and how to test the fix?
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: writeIfNotHere requires an array of strin...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1456#issuecomment-218838201
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 0
Duration: 4h 19m 54s
```
**Summary of the problem(s):**
```
FAIL: Test redundant router internals
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 483, in test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false
"Attempt to retrieve google.com index page should be successful once rule is added!"
AssertionError: Attempt to retrieve google.com index page should be successful once rule is added!
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_MVU2HC/results.txt
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__May_12_2016_05_55_59_X571TZ:`**
* [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1456/tmp/MarvinLogs/DeployDataCenter__May_12_2016_05_55_59_X571TZ/dc_entries.obj)
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1456/tmp/MarvinLogs/DeployDataCenter__May_12_2016_05_55_59_X571TZ/failed_plus_exceptions.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1456/tmp/MarvinLogs/DeployDataCenter__May_12_2016_05_55_59_X571TZ/runinfo.txt)
**`/tmp/MarvinLogs/test_network_MVU2HC:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1456/tmp/MarvinLogs/test_network_MVU2HC/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1456/tmp/MarvinLogs/test_network_MVU2HC/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1456/tmp/MarvinLogs/test_network_MVU2HC/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_routers_9QM5ZD:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1456/tmp/MarvinLogs/test_vpc_routers_9QM5ZD/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1456/tmp/MarvinLogs/test_vpc_routers_9QM5ZD/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1456/tmp/MarvinLogs/test_vpc_routers_9QM5ZD/runinfo.txt)
Uploads will be available until `2016-07-12 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: writeIfNotHere requires an array of strin...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1456#issuecomment-218838385
Can I get another code review so this can be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: writeIfNotHere requires an array of strin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1456
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---