You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/01/06 15:32:54 UTC
[GitHub] [camel-quarkus] aldettinger opened a new pull request #2106: Added Redis Aggregation Repository support in JVM mode only #2085
aldettinger opened a new pull request #2106:
URL: https://github.com/apache/camel-quarkus/pull/2106
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
JVM only as Redisson seems not quarkus native friendly, I'm opening a follow up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #2106: Added Redis Aggregation Repository support in JVM mode only #2085
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #2106:
URL: https://github.com/apache/camel-quarkus/pull/2106#issuecomment-756042655
Yeah, the quarkus community has taken this [path](https://github.com/quarkusio/quarkus/issues/4453#issuecomment-542042896). The potential benefits make it worth taking a look.
As far as I see, changing the underlying client shouldn't break any contract, so I think it is safe to start with redisson JVM only and then upgrade to vertx-redis-client for native.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #2106: Added Redis Aggregation Repository support in JVM mode only #2085
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #2106:
URL: https://github.com/apache/camel-quarkus/pull/2106#issuecomment-755969854
I'm not able to workaround the build issue. But it seems unrelated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger merged pull request #2106: Added Redis Aggregation Repository support in JVM mode only #2085
Posted by GitBox <gi...@apache.org>.
aldettinger merged pull request #2106:
URL: https://github.com/apache/camel-quarkus/pull/2106
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #2106: Added Redis Aggregation Repository support in JVM mode only #2085
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #2106:
URL: https://github.com/apache/camel-quarkus/pull/2106#issuecomment-755994089
Wondering for native support whether we should think about having Camel support for `vertx-redis-client`? Then we could leverage Quarkus Redis and get the native bits for free, rather than spend time on Redisson.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #2106: Added Redis Aggregation Repository support in JVM mode only #2085
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2106:
URL: https://github.com/apache/camel-quarkus/pull/2106#issuecomment-755983285
> I'm not able to workaround the build issue. But it seems unrelated.
See https://github.com/apache/camel-quarkus/pull/2110
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org