[jira] [Resolved] (HBASE-25685) asyncprofiler2.0 no longer supports svg; wants html

["Michael Stack (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-25685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Stack resolved HBASE-25685.
-----------------------------------
    Fix Version/s: 2.4.3
                   2.3.5
                   2.5.0
                   3.0.0-alpha-1
     Hadoop Flags: Reviewed
     Release Note: 
If asyncprofiler 1.x, all is good. If asyncprofiler 2.x and it is hbase-2.3.x or hbase-2.4.x, add '?output=html' to get flamegraphs from the profiler.

Otherwise, if hbase-2.5+ and asyncprofiler2, all works. If asyncprofiler1 and hbase-2.5+, you may have to add '?output=svg' to the query.
       Resolution: Fixed

Thanks for the review [~weichiu]. Pushed #3079 on branch-2.3+branch-2.4. Pushed #3078 on branch-2 and master.

> asyncprofiler2.0 no longer supports svg; wants html
> ---------------------------------------------------
>
>                 Key: HBASE-25685
>                 URL: https://issues.apache.org/jira/browse/HBASE-25685
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Michael Stack
>            Assignee: Wei-Chiu Chuang
>            Priority: Major
>             Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.5, 2.4.3
>
>
> asyncprofiler2.0 is out. Its a nice tool. Unfortunately, it dropped the svg formatting option that we use in our servlet. Now it wants you  to pass html. Lets fix.
> Old -o on asyncprofiler1.x
> -o fmt            output format: summary|traces|flat|collapsed|svg|tree|jfr
> New -o asyncprofiler 2.x
> -o fmt            output format: flat|traces|collapsed|flamegraph|tree|jfr
> If you pass svg to 2.0, it does nothing ... If you run the command hbase is running you see:
> {code}
> /tmp/prof-output$ sudo -u hbase /usr/lib/async-profiler/profiler.sh -e cpu -d 10 -o svg -f /tmp/prof-output/async-prof-pid-8346-cpu-1x.svg 8346
> [ERROR] SVG format is obsolete, use .html for FlameGraph
> {code}
> At a minimum can make it so the OUTPUT param supports HTML. Here is current enum state:
> {code}
>   enum Output {
>     SUMMARY,
>     TRACES,
>     FLAT,
>     COLLAPSED,
>     SVG,
>     TREE,
>     JFR
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)