[GitHub] [libcloud] Kami commented on a change in pull request #1331: Add function to remove a security group from a node in OpenStack driver #1330

[GitBox <gi...@apache.org>]

Kami commented on a change in pull request #1331: Add function to remove a security group from a node in OpenStack driver #1330
URL: https://github.com/apache/libcloud/pull/1331#discussion_r310354443
 
 

 ##########
 File path: libcloud/test/compute/test_openstack.py
 ##########
 @@ -2674,6 +2680,11 @@ def _v2_1337_v2_0_routers_f8a44de0_fc8e_45df_93c7_f79bf3b01c95_remove_router_int
         if method == 'PUT':
             body = self.fixtures.load('_v2_0__router_interface.json')
             return (httplib.OK, body, self.json_content_headers, httplib.responses[httplib.OK])
+
+    def _v2_1337_servers_1000_action(self, method, url, body, headers):
+        if method != 'POST' or body != '{"removeSecurityGroup": {"name": "sgname"}}':
 
 Review comment:
   Good test case :+1: 
   
   We should use such assertions in more places (aka asserting also that the body is correct and not just the path / URL).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services