You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2015/07/02 20:40:06 UTC

[jira] [Comment Edited] (SOLR-7748) Fix bin/solr to work on IBM J9

    [ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612343#comment-14612343 ] 

Hoss Man edited comment on SOLR-7748 at 7/2/15 6:39 PM:
--------------------------------------------------------

bq. With this patch, we have a way to also detect particular build versions and block them if we know they are bad. I don't think the blocking j9 entirely is a good solution though, and definitely the script currently doesn't explicitly block j9, it just fails with a wrong flag passed error.

+1

wether the script should explicitly fail/warn "IBM J9 is known to have problems running Solr" on startup is a question that should be discussed/answered in it's own issue -- it certainly makes sense to me to go ahead and fix the script to not fail in a weird and confusing way just -because your're- (edit) *by the coincidence of*  _trying_ to use J9.

(by corollary: we IndexWriter tests that give up if you try running on J9 because we know those tests are unreliably on J9, but that doesn't mean the IndexWriter class itself throws a RuntimeException if you try to instantiate it on a J9 JVM)




was (Author: hossman):
bq. With this patch, we have a way to also detect particular build versions and block them if we know they are bad. I don't think the blocking j9 entirely is a good solution though, and definitely the script currently doesn't explicitly block j9, it just fails with a wrong flag passed error.

+1

wether the script should explicitly fail/warn "IBM J9 is known to have problems running Solr" on startup is a question that should be discussed/answered in it's own issue -- it certainly makes sense to me to go ahead and fix the script to not fail in a weird and confusing way just because you're _trying_ to use J9.

(by corollary: we IndexWriter tests that give up if you try running on J9 because we know those tests are unreliably on J9, but that doesn't mean the IndexWriter class itself throws a RuntimeException if you try to instantiate it on a J9 JVM)



> Fix bin/solr to work on IBM J9
> ------------------------------
>
>                 Key: SOLR-7748
>                 URL: https://issues.apache.org/jira/browse/SOLR-7748
>             Project: Solr
>          Issue Type: Bug
>          Components: Server
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>             Fix For: 5.3, Trunk
>
>         Attachments: solr-7748.patch
>
>
> bin/solr doesn't work on IBM J9 because it sets -Xloggc flag, while J9 supports -Xverbosegclog. This prevents using bin/solr to start it on J9.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org