You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/11/26 07:59:49 UTC
[GitHub] [incubator-kvrocks] PragmaTwice opened a new pull request, #1144: Split `util.h` to more concrete util headers
PragmaTwice opened a new pull request, #1144:
URL: https://github.com/apache/incubator-kvrocks/pull/1144
As discussed in https://github.com/apache/incubator-kvrocks/pull/973#discussion_r992920261, it seems a header file named `util.h` can lead to a disaster: all functions that we do not know where to put will be placed in this file, making this file cluttered and bloated.
We need more specific file names rather than `util.h`, so in this PR, we separate the functions in `util.h` into different files: `string_util.h`, `io_util.h`, `time_util.h` and `thread_util.h`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1144: Split `util.h` to more concrete util headers
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #1144:
URL: https://github.com/apache/incubator-kvrocks/pull/1144#issuecomment-1328039769
Thanks all. Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice merged pull request #1144: Split `util.h` to more concrete util headers
Posted by GitBox <gi...@apache.org>.
PragmaTwice merged PR #1144:
URL: https://github.com/apache/incubator-kvrocks/pull/1144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org