[GitHub] [tvm] elvin-n commented on a diff in pull request #12833: [DOCKER][Adreno]Docker infra for Adreno target with CLML support

[GitBox <gi...@apache.org>]

elvin-n commented on code in PR #12833:
URL: https://github.com/apache/tvm/pull/12833#discussion_r977607079


##########
tests/python/relay/opencl_texture/test_conv2d_nchw_texture.py:
##########
@@ -577,7 +577,6 @@ def test_residual_block(target, dtype):
         "global.texture-weight",
         "global.texture",
         "global.texture-weight",
-        "global",

Review Comment:
   there are two different graphs produced for fp16 and fp32. the correct fix should be like
   ```
   index 504a2b4e3..8f1c9e1ab 100644
   --- a/tests/python/relay/opencl_texture/test_conv2d_nchw_texture.py
   +++ b/tests/python/relay/opencl_texture/test_conv2d_nchw_texture.py
   @@ -570,19 +570,33 @@ def test_residual_block(target, dtype):
            "weight3": tvm.nd.array(filter_data3),
        }
   -    static_memory_scope = [
   -        "global",
   -        "global.texture",
   -        "global.texture-weight",
   -        "global.texture-weight",
   -        "global.texture",
   -        "global.texture-weight",
   -        "global",
   -        "global.texture",
   -        "global.texture-weight",
   -        "",
   -        "",
   -    ]
   +    if dtype == "float16":
   +        static_memory_scope = [
   +            "global",
   +            "global.texture",
   +            "global.texture-weight",
   +            "global.texture-weight",
   +            "global.texture",
   +            "global.texture-weight",
   +            "global",
   +            "global.texture",
   +            "global.texture-weight",
   +            "",
   +            "",
   +        ]
   +    else:
   +        static_memory_scope = [
   +            "global",
   +            "global.texture",
   +            "global.texture-weight",
   +            "global.texture-weight",
   +            "global.texture",
   +            "global.texture-weight",
   +            "global.texture",
   +            "global.texture-weight",
   +            "",
   +            "",
   +        ]
        build_run_compare(mod, params1, {"data": input_shape}, dtype, target, static_memory_scope)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org