You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/08/16 05:38:41 UTC

[GitHub] [netbeans] lkishalmi opened a new pull request, #4509: Refactor Grade Editor related functionality into a gradle.editor module

lkishalmi opened a new pull request, #4509:
URL: https://github.com/apache/netbeans/pull/4509

   Dear all,
   
   This is a part of an effort trying to split up the ```gradle``` module into smaller parts with less dependencies. So this would start a series.
   
   For me this is the second take of the work, as at first I started with moving the editor related parts to a new module. It was just too late when I realized that the ```GradleReport``` class never reached the ```api``` package (though we have an entry on that in the ```apichanges.xml```)
   
   I broke up the work for meaningful units in the commits, so it maybe easier to review this change commit by commit.
   
   I don't necessary like the exploiting to the ```NbGradleProjectImpl.ACCESSOR```, though that was handy to hide the constructors from the API users.
   
   I'm not fun of the names ```GradleReport``` maybe Ok, but ```GradleProblemReport``` is an ehh.
   
   So suggestions, and feedback are required! Till it's a draft, the Javadoc stuff are not ready.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] lkishalmi commented on pull request #4509: Refactor Grade Editor related functionality into a gradle.editor module

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #4509:
URL: https://github.com/apache/netbeans/pull/4509#issuecomment-1221217001

   Closed in favor of: #4518


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] lkishalmi closed pull request #4509: Refactor Grade Editor related functionality into a gradle.editor module

Posted by GitBox <gi...@apache.org>.
lkishalmi closed pull request #4509: Refactor Grade Editor related functionality into a gradle.editor module
URL: https://github.com/apache/netbeans/pull/4509


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists