[jira] [Commented] (KAFKA-4225) Replication Quotas: Control Leader & Follower Limit Separately

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530714#comment-15530714 ] 

ASF GitHub Bot commented on KAFKA-4225:
---------------------------------------

GitHub user benstopford opened a pull request:

    https://github.com/apache/kafka/pull/1928

    KAFKA-4225: Replication Quotas: Control Leader & Follower Limit Separately

    See final commit. 
    
    (depends on https://github.com/apache/kafka/pull/1906)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benstopford/kafka KAFKA-4225-over-KAFKA-4216

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1928.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1928
    
----
commit ddcb115fa6a098cef79209ae8022a4467b8ea873
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-26T14:26:11Z

    KAFKA-4216: First cut of split of leader/follwer replica lists.

commit bee043a85f4f8034785f3f83447e732dcd8d316e
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-26T15:34:41Z

    KAFKA-4216: Refactored the way we calculate which replicas should be throttled. No functional change in this commit.

commit 1c416f465ccfe6c9c57c2e6e86c71616034e8b99
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-27T09:12:05Z

    KAFKA-4177: Refactored the way we derive the throttled replica list (it was super ugly). No functional change

commit 637316e23a4cd3290101dd62080158a36c63f57c
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-27T09:17:54Z

    KAFKA-4177: Formatting only based on Jun's feedback

commit 2e20c50c94242e9a1a59cfdb826cb68739e5bed0
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-27T09:24:03Z

    KAFKA-4177: remove reformatting of license file text

commit 70f263e1b6371bb27a1afd33299cf378cd8d3f67
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-27T14:36:46Z

    KAFKA-4216: small formatting change.

commit bc07a348283aa307bde6a32d0cf7e84cb7b1ad64
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-27T14:46:52Z

    KAFKA-4216: Improved comments

commit bab1c38a370f8d0b73ac9a3ed40880da4ee95e38
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-28T10:59:46Z

    KAFKA-4216: Consolidated code that creates properties

commit 97acd19854b19564b9db4aac3166d18fdcd9ce0f
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-28T14:59:47Z

    KAFKA-4216: Change throttled replica list property to be of type LIST not STRING

commit 17af1e728d3e32a44ea0cbcee1967e31ce401ca1
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-28T15:26:38Z

    KAFKA-4216: Stylistic / logging changes only

commit faedb50f8646a24da94bac2ed047dcda326bdb8d
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-28T16:13:07Z

    KAFKA-4216: Added validation to ensure that all partitions in the proposed assignment exist in the cluster

commit b39a4a4870dca46750b4063e79b1b8fc8aaf79df
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-28T16:23:13Z

    KAFKA-4216: Small change to add distinct to the topic selection

commit ae65db17eb53e5822e7bc137fc94c2ee7c73392f
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-28T16:24:42Z

    KAFKA-4216: Alteration to previous commit. One of the distict calls was not needed.

commit dd2d161cb0dc5ad785f93427cfc7a63c9ebbdb14
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-28T16:26:34Z

    KAFKA-4216: Removed long line

commit 5080f9560b7657e552564aca35e633a322631b48
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-28T16:34:39Z

    KAFKA-4216: Ismael's suggested '(proposed(tp).toSet -- current)' change

commit 67ac7bea374764100a79033e4245f7c09a6d435b
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-28T16:37:07Z

    KAFKA-4216: Ismael's suggestion to format method

commit 797fded9d9b9d1df1f4b76fbbae74dad07b98ee8
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-28T16:40:13Z

    KAFKA-4216: Stylistic changes.

commit 5d06a265847d558ad60c1b82c9bfb1b30dce47b0
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-28T16:41:11Z

    KAFKA-4216: Add text to fail()

commit 84b5602e01636bb8ffa7cdabe1e9b782d67f5e22
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-28T17:32:58Z

    KAFKA-4216: silly error in test.

commit 784c5cdf81be1abf13b8959cf7d3f3bbef2c2d12
Author: Ben Stopford <be...@gmail.com>
Date:   2016-09-28T19:40:52Z

    KAFKA-4225: Replication Quotas: Control Leader & Follower Limit Separately

----


> Replication Quotas: Control Leader & Follower Limit Separately
> --------------------------------------------------------------
>
>                 Key: KAFKA-4225
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4225
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.10.1.0
>            Reporter: Ben Stopford
>            Assignee: Ben Stopford
>
> As we split the throttled replicas into Leader and Follower configs, it makes sense to also split the throttle limit:
> replication.quota.throttled.rate
>    =>
> replication.leader.quota.throttled.rate
> & 
> replication.follower.quota.throttled.rate
> So that admins have fine grain control over both sides of the replication process and the properties match for leader/follower applicability.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)