You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/23 08:16:37 UTC
[GitHub] TisonKun edited a comment on issue #6737: [FLINK-10399] Refractor
ParameterTool#fromArgs
TisonKun edited a comment on issue #6737: [FLINK-10399] Refractor ParameterTool#fromArgs
URL: https://github.com/apache/flink/pull/6737#issuecomment-423799819
Follow the review guide, I would firstly ask for the consensus of this refractor.
I think it is worth because the original one is quite mess and weird. Clean code can express purpose better and prevent us from potential bugs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services