You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Devaraj Das (JIRA)" <ji...@apache.org> on 2010/02/21 18:37:27 UTC

[jira] Created: (HADOOP-6583) Capture metrics for authentication/authorization at the RPC layer

Capture metrics for authentication/authorization at the RPC layer
-----------------------------------------------------------------

                 Key: HADOOP-6583
                 URL: https://issues.apache.org/jira/browse/HADOOP-6583
             Project: Hadoop Common
          Issue Type: Improvement
          Components: ipc, security
    Affects Versions: 0.22.0
            Reporter: Devaraj Das
            Assignee: Devaraj Das
             Fix For: 0.22.0


Define metrics for authentication/authorization for the RPC layer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6583) Capture metrics for authentication/authorization at the RPC layer

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836966#action_12836966 ] 

Hudson commented on HADOOP-6583:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #180 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/180/])
    . Captures authentication and authorization metrics. Contributed by Devaraj Das.


> Capture metrics for authentication/authorization at the RPC layer
> -----------------------------------------------------------------
>
>                 Key: HADOOP-6583
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6583
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc, security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6583-1.patch, 6583-2.patch
>
>
> Define metrics for authentication/authorization for the RPC layer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6583) Capture metrics for authentication/authorization at the RPC layer

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836920#action_12836920 ] 

Owen O'Malley commented on HADOOP-6583:
---------------------------------------

+1

> Capture metrics for authentication/authorization at the RPC layer
> -----------------------------------------------------------------
>
>                 Key: HADOOP-6583
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6583
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc, security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6583-1.patch, 6583-2.patch
>
>
> Define metrics for authentication/authorization for the RPC layer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6583) Capture metrics for authentication/authorization at the RPC layer

Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837020#action_12837020 ] 

Boris Shkolnik commented on HADOOP-6583:
----------------------------------------

by putting authenticationSuccesses.inc() into processOneRpc() , you are counting all RPC calls, including heartBeats.
Is this what we want?


> Capture metrics for authentication/authorization at the RPC layer
> -----------------------------------------------------------------
>
>                 Key: HADOOP-6583
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6583
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc, security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6583-1.patch, 6583-2.patch, 6583-bp20.patch
>
>
> Define metrics for authentication/authorization for the RPC layer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6583) Capture metrics for authentication/authorization at the RPC layer

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836424#action_12836424 ] 

Hadoop QA commented on HADOOP-6583:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12436516/6583-2.patch
  against trunk revision 912207.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/console

This message is automatically generated.

> Capture metrics for authentication/authorization at the RPC layer
> -----------------------------------------------------------------
>
>                 Key: HADOOP-6583
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6583
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc, security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6583-1.patch, 6583-2.patch
>
>
> Define metrics for authentication/authorization for the RPC layer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6583) Capture metrics for authentication/authorization at the RPC layer

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6583:
--------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this.

> Capture metrics for authentication/authorization at the RPC layer
> -----------------------------------------------------------------
>
>                 Key: HADOOP-6583
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6583
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc, security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6583-1.patch, 6583-2.patch
>
>
> Define metrics for authentication/authorization for the RPC layer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6583) Capture metrics for authentication/authorization at the RPC layer

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836409#action_12836409 ] 

Hadoop QA commented on HADOOP-6583:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12436504/6583-1.patch
  against trunk revision 912207.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/25/console

This message is automatically generated.

> Capture metrics for authentication/authorization at the RPC layer
> -----------------------------------------------------------------
>
>                 Key: HADOOP-6583
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6583
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc, security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6583-1.patch
>
>
> Define metrics for authentication/authorization for the RPC layer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6583) Capture metrics for authentication/authorization at the RPC layer

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6583:
--------------------------------

    Status: Patch Available  (was: Open)

> Capture metrics for authentication/authorization at the RPC layer
> -----------------------------------------------------------------
>
>                 Key: HADOOP-6583
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6583
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc, security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6583-1.patch, 6583-2.patch
>
>
> Define metrics for authentication/authorization for the RPC layer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6583) Capture metrics for authentication/authorization at the RPC layer

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6583:
--------------------------------

    Attachment: 6583-2.patch

Had forgotten to update my local repository before creating the patch. In this patch, I also changed the approach to use the existing RpcMetrics instead of defining a new one for security.

> Capture metrics for authentication/authorization at the RPC layer
> -----------------------------------------------------------------
>
>                 Key: HADOOP-6583
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6583
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc, security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6583-1.patch, 6583-2.patch
>
>
> Define metrics for authentication/authorization for the RPC layer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6583) Capture metrics for authentication/authorization at the RPC layer

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6583:
--------------------------------

    Status: Patch Available  (was: Open)

> Capture metrics for authentication/authorization at the RPC layer
> -----------------------------------------------------------------
>
>                 Key: HADOOP-6583
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6583
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc, security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6583-1.patch
>
>
> Define metrics for authentication/authorization for the RPC layer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6583) Capture metrics for authentication/authorization at the RPC layer

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837302#action_12837302 ] 

Hudson commented on HADOOP-6583:
--------------------------------

Integrated in Hadoop-Common-trunk #258 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/258/])
    . Captures authentication and authorization metrics. Contributed by Devaraj Das.


> Capture metrics for authentication/authorization at the RPC layer
> -----------------------------------------------------------------
>
>                 Key: HADOOP-6583
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6583
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc, security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6583-1.patch, 6583-2.patch, 6583-bp20.patch
>
>
> Define metrics for authentication/authorization for the RPC layer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6583) Capture metrics for authentication/authorization at the RPC layer

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6583:
--------------------------------

    Status: Open  (was: Patch Available)

> Capture metrics for authentication/authorization at the RPC layer
> -----------------------------------------------------------------
>
>                 Key: HADOOP-6583
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6583
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc, security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6583-1.patch
>
>
> Define metrics for authentication/authorization for the RPC layer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6583) Capture metrics for authentication/authorization at the RPC layer

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6583:
--------------------------------

    Attachment: 6583-1.patch

The authentication/authorization successes/failures are captured.

> Capture metrics for authentication/authorization at the RPC layer
> -----------------------------------------------------------------
>
>                 Key: HADOOP-6583
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6583
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc, security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6583-1.patch
>
>
> Define metrics for authentication/authorization for the RPC layer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6583) Capture metrics for authentication/authorization at the RPC layer

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6583:
--------------------------------

    Attachment: 6583-bp20.patch

Patch for Y20. Not for commit here.

> Capture metrics for authentication/authorization at the RPC layer
> -----------------------------------------------------------------
>
>                 Key: HADOOP-6583
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6583
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc, security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6583-1.patch, 6583-2.patch, 6583-bp20.patch
>
>
> Define metrics for authentication/authorization for the RPC layer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.