[GitHub] [superset] michael-s-molina commented on pull request #23387: fix(sql lab): Tracking URL getter/setter

["michael-s-molina (via GitHub)" <gi...@apache.org>]

michael-s-molina commented on PR #23387:
URL: https://github.com/apache/superset/pull/23387#issuecomment-1472298776

   > Typically the getter should simply return the value whereas the setter should perform the necessary augmentation which is the logic I've implemented here, i.e., the _tracking_url column always contains the correct transformed value (if appropriate) whereas previous only the tracking_url field (proxy) was correct.
   
   @john-bodley Would we need a migration to transform previously saved values?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org