[GitHub] [nifi] mattyb149 commented on a change in pull request #5762: NIFI-9425: Added auto-load NAR capability to MiNiFi

[GitBox <gi...@apache.org>]

mattyb149 commented on a change in pull request #5762:
URL: https://github.com/apache/nifi/pull/5762#discussion_r819064680



##########
File path: minifi/minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-runtime/src/main/java/org/apache/nifi/minifi/MiNiFi.java
##########
@@ -85,7 +85,7 @@ public MiNiFi(final NiFiProperties properties, ClassLoader rootClassLoader)
         // register the shutdown hook
         Runtime.getRuntime().addShutdownHook(new Thread(() -> {
             // shutdown the jetty server
-            shutdownHook(true);
+            shutdownHook(false);

Review comment:
       I don't believe it should reload at that point (indeed NiFi has it set to false), setting it true causes the close() method to be called twice although I did put defensive code around that in this PR just in case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org