You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/02/03 04:11:51 UTC
[GitHub] [iotdb] weizihan0110 opened a new pull request #2614: [IOTDB-1142] Fix deleting timeseries error
weizihan0110 opened a new pull request #2614:
URL: https://github.com/apache/iotdb/pull/2614
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on pull request #2614: Fix deleting timeseries error
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #2614:
URL: https://github.com/apache/iotdb/pull/2614#issuecomment-771367107
Hei, PR description (what it is, why it happens, and how to solve it) must be written.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] weizihan0110 closed pull request #2614: [IOTDB-1142] Fix deleting timeseries error
Posted by GitBox <gi...@apache.org>.
weizihan0110 closed pull request #2614:
URL: https://github.com/apache/iotdb/pull/2614
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] weizihan0110 commented on pull request #2614: [IOTDB-1142] Fix deleting timeseries error
Posted by GitBox <gi...@apache.org>.
weizihan0110 commented on pull request #2614:
URL: https://github.com/apache/iotdb/pull/2614#issuecomment-795156036
> Hi, as is discussed in mail list and JIRA, we intend to use `*` and `**`:
>
> We could reference the usage of wild star in Linux :
>
> ```
> /tmp/* matches any file in /tmp. // Substitutes for any number of characters, except /.
> /tmp/** matches all files and directories underneath /tmp. // Substitutes for any number of characters, including /.
> ```
>
> So we should also consider that `**` also contains zero layer.
> For example, if we have some storage groups:
>
> ```
> root.a.sg1
> root.a.b.sg2
> root.b.sg3
> ```
>
> For "delete storage group root.a", we do not delete any sg.
> For "delete storage group root.a.*" we delete root.a.sg1
> For "delete storage group root.a.sg1.*" we do not delete any sg.
> For "delete storage group root.a.**" we delete root.a.sg1, root.a.b.sg2
>
> If we also have another storage group `root.a`:
>
> For "delete storage group root.a", we delete root.a
> For "delete storage group root.a.*" we delete root.a.sg1 (because * does not include zero layer)
> For "delete storage group root.a.**" we delete root.a, root.a.sg1, root.a.b.sg2 (because ** includes zero layer)
Hi, @samperson1997. I got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on pull request #2614: Fix deleting timeseries error
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #2614:
URL: https://github.com/apache/iotdb/pull/2614#issuecomment-771367107
Hei, PR description (what it is, why it happens, and how to solve it) must be written.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] weizihan0110 removed a comment on pull request #2614: [IOTDB-1142] Fix deleting timeseries error
Posted by GitBox <gi...@apache.org>.
weizihan0110 removed a comment on pull request #2614:
URL: https://github.com/apache/iotdb/pull/2614#issuecomment-795152247
I got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] weizihan0110 commented on pull request #2614: [IOTDB-1142] Fix deleting timeseries error
Posted by GitBox <gi...@apache.org>.
weizihan0110 commented on pull request #2614:
URL: https://github.com/apache/iotdb/pull/2614#issuecomment-795152247
I got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] samperson1997 commented on pull request #2614: [IOTDB-1142] Fix deleting timeseries error
Posted by GitBox <gi...@apache.org>.
samperson1997 commented on pull request #2614:
URL: https://github.com/apache/iotdb/pull/2614#issuecomment-793731792
Hi, as is discussed in mail list and JIRA, we intend to use `*` and `**`:
We could reference the usage of wild star in Linux :
```
/tmp/* matches any file in /tmp. // Substitutes for any number of characters, except /.
/tmp/** matches all files and directories underneath /tmp. // Substitutes for any number of characters, including /.
```
So we should also consider that `**` also contains zero layer.
For example, if we have some storage groups:
```
root.a.sg1
root.a.b.sg2
root.b.sg3
```
For "delete storage group root.a", we do not delete any sg.
For "delete storage group root.a.\*" we delete root.a.sg1
For "delete storage group root.a.sg1.\*" we do not delete any sg.
For "delete storage group root.a.\*\*" we delete root.a.sg1, root.a.b.sg2
If we also have another storage group `root.a`:
For "delete storage group root.a", we delete root.a
For "delete storage group root.a.*" we delete root.a.sg1 (because * does not include zero layer)
For "delete storage group root.a.**" we delete root.a, root.a.sg1, root.a.b.sg2 (because ** includes zero layer)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou closed pull request #2614: [IOTDB-1142] Fix deleting timeseries error
Posted by GitBox <gi...@apache.org>.
HTHou closed pull request #2614:
URL: https://github.com/apache/iotdb/pull/2614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] weizihan0110 closed pull request #2614: [IOTDB-1142] Fix deleting timeseries error
Posted by GitBox <gi...@apache.org>.
weizihan0110 closed pull request #2614:
URL: https://github.com/apache/iotdb/pull/2614
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #2614: [IOTDB-1142] Fix deleting timeseries error
Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #2614:
URL: https://github.com/apache/iotdb/pull/2614#issuecomment-908826001
We disabled the usage of nested timeseries path, therefore it would not be a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou closed pull request #2614: [IOTDB-1142] Fix deleting timeseries error
Posted by GitBox <gi...@apache.org>.
HTHou closed pull request #2614:
URL: https://github.com/apache/iotdb/pull/2614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #2614: [IOTDB-1142] Fix deleting timeseries error
Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #2614:
URL: https://github.com/apache/iotdb/pull/2614#issuecomment-908826001
We disabled the usage of nested timeseries path, therefore it would not be a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org