[GitHub] [skywalking] zifeihan commented on a change in pull request #5987: Fix logger-plugin module directory structure problem(Maven cannot trigger junit testing).

[GitBox <gi...@apache.org>]

zifeihan commented on a change in pull request #5987:
URL: https://github.com/apache/skywalking/pull/5987#discussion_r540701879



##########
File path: apm-sniffer/optional-plugins/logger-plugin/src/test/java/org/apache/skywalking/apm/plugin/logger/ContextConfigDefaultTest.java
##########
@@ -24,7 +25,7 @@
 public class ContextConfigDefaultTest {
     @Test
     public void testDefaultConfig() {
-        ContextConfig config = ContextConfig.getInstance();
+        ContextConfig config = ContextConfig.getLatestConfig();

Review comment:
       @vcjmhg Hello, because maven test is in a jvm instance, the loading configuration file content is in singleton mode, so if the file content is modified in the test case, it will not take effect.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org