You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/25 20:00:19 UTC
[GitHub] [airflow] potiuk opened a new pull request #13314: Refactor setup py
potiuk opened a new pull request #13314:
URL: https://github.com/apache/airflow/pull/13314
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751293232
[The Workflow run](https://github.com/apache/airflow/actions/runs/444592722) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751358035
And added extra column for pre-installed providers (and verification if the docs match setup.py).
I also removed circular dependency from the preinstalled providers (provider -> airflow -> provider) and updated the package dependency to >=2.0.0 (it was >=2.0.0b2). This was not a problem in general but some tools (pipdeptree) shown the circular dependncy as a warning.
@ashb -> that means that I had to move the providers to setup.py from setup.cfg (to be able to easier verify it) but I think it makes perfect sense in this case.
Here is the updated pre-commit message printed if the setup.py gets unsynchronized with the documentation:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751358501
cc: @szn -> finally I refactored the setup.py, got rid of the TODO comments (in favour of separate dictionary for aliases). That allowed to simplify and refactor your original code (finally we could import setup.py rather than parse it with regexps). Your code lives on ;).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751363347
And example generated dependencies:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751360873
[The Workflow run](https://github.com/apache/airflow/actions/runs/445600824) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751288816
[The Workflow run](https://github.com/apache/airflow/actions/runs/444523881) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751353069
[The Workflow run](https://github.com/apache/airflow/actions/runs/445510990) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751357154
[The Workflow run](https://github.com/apache/airflow/actions/runs/445566832) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751813274
Random failure. Merging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751373828
[The Workflow run](https://github.com/apache/airflow/actions/runs/445770622) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751365403
Also updated the comments in setup.py and cleaned-up some typos with file paths that changed in the meantime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751352626
@houqp I simplified it a bit more. I wanted to used NamedTuples first so I turned Dicts into Lists but this was a bad idea so I converted back `PROVIDERS_REQUIREMENTS` and `EXTRAS_DEPRECATED_ALIASES` to Dicts. That makes much more sense and simplifies some further manipulations with those, including the pre-commits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751398529
[The Workflow run](https://github.com/apache/airflow/actions/runs/446068270) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751367195
Another part of this change is vastly enriched output of 'setup-order' pre-commit. It will not only check everything for order but also will print what is being checked. I found out that several lists were wrongly ordered because some regular expressions were "stopping" comparison when there was '[" as part of requirement (so anything behind requirements with extras could be unsorted). Now you can see exactly what is being checked.
You can try yourself by:
```
pre-commit run setup-order -v --all-files
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751321355
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751305801
[The Workflow run](https://github.com/apache/airflow/actions/runs/444807001) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751362458
[The Workflow run](https://github.com/apache/airflow/actions/runs/445621107) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751291463
[The Workflow run](https://github.com/apache/airflow/actions/runs/444566665) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751286871
The setup.py should be much more straightforward and easier to understand now with all the extras-> providers relationships.
Also, the reference documents are now better reflecting relity and pre-commits are catching many more errors (I actually found and fixed quite a few documentation/setup inconsistencies while doing it:
Example error report printed when there are discrepancies setup.py vs. documentation:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751286871
The setup.py should be much more straightforward and easier to understand now with all the extras-> providers relationships.
Also, the reference documents are now better reflecting relity and pre-commits are catching many more errors (I actually found and fixed quite a few documentation/setup inconsistencies while doing it:
Example error report printed when there are discrepancies setup.py vs. documentation:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751363347
And example generated dependencies - including some aliases and 'combined' dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13314:
URL: https://github.com/apache/airflow/pull/13314
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13314: Refactored setup.py to better reflect changes in providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13314:
URL: https://github.com/apache/airflow/pull/13314#issuecomment-751347933
[The Workflow run](https://github.com/apache/airflow/actions/runs/445437932) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org