[jira] [Commented] (LUCENE-6391) Give SpanScorer two-phase iterator support.

["Adrien Grand (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394685#comment-14394685 ] 

Adrien Grand commented on LUCENE-6391:
--------------------------------------

The patch looks good. As far as testing is concerned I guess we're already covered by TestSpanSearchEquivalence.

Thanks!

> Give SpanScorer two-phase iterator support.
> -------------------------------------------
>
>                 Key: LUCENE-6391
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6391
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-6391.patch
>
>
> Fix SpanScorer to use any two-phase iterator support of the underlying Spans. This means e.g. a spans in a booleanquery, or a spans with a filter can be faster.
> In order to do this, we have to clean up this class a little bit:
> * forward most methods directly to the underlying spans.
> * ensure positions are only iterated at most once.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org