You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2021/11/03 10:30:20 UTC
[GitHub] [buildstream] gtristan opened a new pull request #1533: Support creation of /dev/shm in the sandbox
gtristan opened a new pull request #1533:
URL: https://github.com/apache/buildstream/pull/1533
This is a continuation of the work in #1418 and this pull request replaces it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] juergbi commented on a change in pull request #1533: Support creation of /dev/shm in the sandbox
Posted by GitBox <gi...@apache.org>.
juergbi commented on a change in pull request #1533:
URL: https://github.com/apache/buildstream/pull/1533#discussion_r742636627
##########
File path: tests/integration/project/elements/sandbox-bwrap/build-dev-shm-not-mounted.bst
##########
@@ -0,0 +1,11 @@
+kind: manual
+
+depends:
+- base.bst
+
+config:
+ create-dev-shm: false
+
+ build-commands:
+ - |
+ mountpoint -q /dev/shm || true
Review comment:
This will always succeed. To ensure it's not mounted we need something like:
```! mountpoint -q /dev/shm```
##########
File path: tests/integration/project/elements/sandbox-bwrap/script-dev-shm-not-mounted.bst
##########
@@ -0,0 +1,11 @@
+kind: script
+
+build-depends:
+- base.bst
+
+config:
+ create-dev-shm: false
+
+ commands:
+ - |
+ mountpoint -q /dev/shm || true
Review comment:
Same here, this will always succeed. To ensure it's not mounted we need something like:
```! mountpoint -q /dev/shm```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on a change in pull request #1533: Support creation of /dev/shm in the sandbox
Posted by GitBox <gi...@apache.org>.
gtristan commented on a change in pull request #1533:
URL: https://github.com/apache/buildstream/pull/1533#discussion_r742664416
##########
File path: tests/integration/project/elements/sandbox-bwrap/script-dev-shm-not-mounted.bst
##########
@@ -0,0 +1,11 @@
+kind: script
+
+build-depends:
+- base.bst
+
+config:
+ create-dev-shm: false
+
+ commands:
+ - |
+ mountpoint -q /dev/shm || true
Review comment:
Done
##########
File path: tests/integration/project/elements/sandbox-bwrap/build-dev-shm-not-mounted.bst
##########
@@ -0,0 +1,11 @@
+kind: manual
+
+depends:
+- base.bst
+
+config:
+ create-dev-shm: false
+
+ build-commands:
+ - |
+ mountpoint -q /dev/shm || true
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan merged pull request #1533: Support creation of /dev/shm in the sandbox
Posted by GitBox <gi...@apache.org>.
gtristan merged pull request #1533:
URL: https://github.com/apache/buildstream/pull/1533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org