[GitHub] [pinot] walterddr commented on pull request #11153: add theta sketch scalar

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on PR #11153:
URL: https://github.com/apache/pinot/pull/11153#issuecomment-1648299309

   > This is pretty cool, but I'd suggest we prefix the function names with sketch types, ie `THETA_SKETCH_GET_ESTIMATE`, since we use different sketches (KLL, Tuples etc.) and more coming.
   
   Ahh. LOL i didn't know KLL and Tuples are actually a different sketches :-) thank you for the notes. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org