Re: Review Request 67460: Enable stouttest EnvTest.EraseEnv.

[Mesos Reviewbot Windows <re...@mesos.apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67460/#review204352
-----------------------------------------------------------



PASS: Mesos patch 67460 was successfully built and tested.

Reviews applied: `['67460']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67460

- Mesos Reviewbot Windows


On June 5, 2018, 2:17 p.m., Radhika Jandhyala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67460/
> -----------------------------------------------------------
> 
> (Updated June 5, 2018, 2:17 p.m.)
> 
> 
> Review request for Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-5813
>     https://issues.apache.org/jira/browse/MESOS-5813
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable stouttest EnvTest.EraseEnv.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/os/env_tests.cpp b5b124dc6316e661af6dd90335ade5283c26d9f2 
> 
> 
> Diff: https://reviews.apache.org/r/67460/diff/1/
> 
> 
> Testing
> -------
> 
> Here is one test I could enable for windows. However, one thing I notice is that the original test specifically wanted to call ::getenv which I had to change to os::getenv. So the test is a little different now. I can abandon this review if you think that makes more sense.
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>