You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bi...@apache.org on 2002/09/19 06:21:17 UTC
cvs commit: jakarta-tomcat/src/shell tomcat.bat tomcat.sh
billbarker 2002/09/18 21:21:17
Modified: src/shell tomcat.bat tomcat.sh
Log:
Temporary stop-gap until I work out all of the ClassLoader issues.
Revision Changes Path
1.47 +2 -2 jakarta-tomcat/src/shell/tomcat.bat
Index: tomcat.bat
===================================================================
RCS file: /home/cvs/jakarta-tomcat/src/shell/tomcat.bat,v
retrieving revision 1.46
retrieving revision 1.47
diff -u -r1.46 -r1.47
--- tomcat.bat 28 Mar 2002 02:29:00 -0000 1.46
+++ tomcat.bat 19 Sep 2002 04:21:17 -0000 1.47
@@ -97,7 +97,7 @@
:setClasspath
-set CLASSPATH=%TOMCAT_INSTALL%\lib\tomcat.jar
+set CLASSPATH=%TOMCAT_INSTALL%\lib\tomcat.jar;%TOMCAT_INSTALL%\lib\common\commons-logging.jar
rem ----- Execute The Requested Command -------------------------------------
1.34 +2 -2 jakarta-tomcat/src/shell/tomcat.sh
Index: tomcat.sh
===================================================================
RCS file: /home/cvs/jakarta-tomcat/src/shell/tomcat.sh,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -r1.33 -r1.34
--- tomcat.sh 18 Apr 2002 13:58:01 -0000 1.33
+++ tomcat.sh 19 Sep 2002 04:21:17 -0000 1.34
@@ -117,7 +117,7 @@
oldCP=$CLASSPATH
unset CLASSPATH
-CLASSPATH=${TOMCAT_INSTALL}/lib/tomcat.jar
+CLASSPATH=${TOMCAT_INSTALL}/lib/tomcat.jar:${TOMCAT_INSTALL}/lib/common/commons-logging.jar
# Ignore previous CLASSPATH
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-tomcat/src/shell tomcat.bat tomcat.sh
Posted by Costin Manolache <cm...@yahoo.com>.
Bill Barker wrote:
> I went ahead and converted most of j-t o.a.t.util.** to use
> commons-logging. At the moment, since o.a.t.u.depend and o.a.t.u.compat
> are in the System ClassLoader, then commons-logging needs to be there as
> well.
+1
We shoud do it for j-t-c o.a.t.util as well, if not already done ( but
after 4.1 is out ).
IMPORNTANT: it's commons-logging-api.jar that should be in common loader !!
( I assume that's what you meant, just want to be sure everyone is aware of
this issue ).
The -api.jar was created exactly to allow this kind of setup, with
commons-logging in the parent loader and different child loaders using
different logging implementations.
Costin
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-tomcat/src/shell tomcat.bat tomcat.sh
Posted by Bill Barker <wb...@wilshire.com>.
----- Original Message -----
From: "Costin Manolache" <cm...@yahoo.com>
To: <to...@jakarta.apache.org>
Sent: Monday, September 23, 2002 3:57 AM
Subject: Re: cvs commit: jakarta-tomcat/src/shell tomcat.bat tomcat.sh
> Bill Barker wrote:
>
> >
> > ----- Original Message -----
> > From: <bi...@apache.org>
> > To: <ja...@apache.org>
> > Sent: Wednesday, September 18, 2002 9:21 PM
> > Subject: cvs commit: jakarta-tomcat/src/shell tomcat.bat tomcat.sh
> >
> >
> >> billbarker 2002/09/18 21:21:17
> >>
> >> Modified: src/shell tomcat.bat tomcat.sh
> >> Log:
> >> Temporary stop-gap until I work out all of the ClassLoader issues.
> >>
> >
> > Ok, there are a couple of options here:
> > 1) Add a Class-Path to the Manifest (and make a comment in the release
> > notes for people using Java 1.1.x).
> >
> > 2) Revert o.a.t.u.compat.* and o.a.t.u.depend.* to using System.err
> > instead of c-l, since they are loaded in the System ClassLoader when
> > running from the scripts.
> >
> > 3) Re-implement the required methods from o.a.t.u.compat.* in
> > o.a.t.startup.Main so that we can leave o.a.t.u.depend.* and
> > o.a.t.u.compat.* out of the jar.
> >
> > My personal choices are in order, 3-1-2. However 1 is the easiest, and
> > seems to be in the direction that the proposals are heading.
> >
> > Opinions (Larry/Costin)?
>
> I used to like a lot (1), however I've been bitten few times. I still
> think it is a good solution, but with a lot of care.
>
> (2) is very easy to implement, and can solve the problem.
>
> The big question is: do we want to keep the very small/minimal parent
> loader - with commons-logging-api in the container loader ?
>
> BTW, I'm not sure what was the original problem you are trying
> to solve. I have a lot of mail to sort through, I would apreciate
> some more context info :-)
I went ahead and converted most of j-t o.a.t.util.** to use commons-logging.
At the moment, since o.a.t.u.depend and o.a.t.u.compat are in the System
ClassLoader, then commons-logging needs to be there as well.
>
> --
> Costin
>
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-tomcat/src/shell tomcat.bat tomcat.sh
Posted by Costin Manolache <cm...@yahoo.com>.
Bill Barker wrote:
>
> ----- Original Message -----
> From: <bi...@apache.org>
> To: <ja...@apache.org>
> Sent: Wednesday, September 18, 2002 9:21 PM
> Subject: cvs commit: jakarta-tomcat/src/shell tomcat.bat tomcat.sh
>
>
>> billbarker 2002/09/18 21:21:17
>>
>> Modified: src/shell tomcat.bat tomcat.sh
>> Log:
>> Temporary stop-gap until I work out all of the ClassLoader issues.
>>
>
> Ok, there are a couple of options here:
> 1) Add a Class-Path to the Manifest (and make a comment in the release
> notes for people using Java 1.1.x).
>
> 2) Revert o.a.t.u.compat.* and o.a.t.u.depend.* to using System.err
> instead of c-l, since they are loaded in the System ClassLoader when
> running from the scripts.
>
> 3) Re-implement the required methods from o.a.t.u.compat.* in
> o.a.t.startup.Main so that we can leave o.a.t.u.depend.* and
> o.a.t.u.compat.* out of the jar.
>
> My personal choices are in order, 3-1-2. However 1 is the easiest, and
> seems to be in the direction that the proposals are heading.
>
> Opinions (Larry/Costin)?
I used to like a lot (1), however I've been bitten few times. I still
think it is a good solution, but with a lot of care.
(2) is very easy to implement, and can solve the problem.
The big question is: do we want to keep the very small/minimal parent
loader - with commons-logging-api in the container loader ?
BTW, I'm not sure what was the original problem you are trying
to solve. I have a lot of mail to sort through, I would apreciate
some more context info :-)
--
Costin
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-tomcat/src/shell tomcat.bat tomcat.sh
Posted by Bill Barker <wb...@wilshire.com>.
----- Original Message -----
From: <bi...@apache.org>
To: <ja...@apache.org>
Sent: Wednesday, September 18, 2002 9:21 PM
Subject: cvs commit: jakarta-tomcat/src/shell tomcat.bat tomcat.sh
> billbarker 2002/09/18 21:21:17
>
> Modified: src/shell tomcat.bat tomcat.sh
> Log:
> Temporary stop-gap until I work out all of the ClassLoader issues.
>
Ok, there are a couple of options here:
1) Add a Class-Path to the Manifest (and make a comment in the release notes
for people using Java 1.1.x).
2) Revert o.a.t.u.compat.* and o.a.t.u.depend.* to using System.err instead
of c-l, since they are loaded in the System ClassLoader when running from
the scripts.
3) Re-implement the required methods from o.a.t.u.compat.* in
o.a.t.startup.Main so that we can leave o.a.t.u.depend.* and
o.a.t.u.compat.* out of the jar.
My personal choices are in order, 3-1-2. However 1 is the easiest, and
seems to be in the direction that the proposals are heading.
Opinions (Larry/Costin)?
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>