You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/19 13:53:33 UTC

[GitHub] [flink] dannycranmer opened a new pull request #15290: [FLINK-21875][hotfix] Fix compilation error in IntelliJ for GSR test

dannycranmer opened a new pull request #15290:
URL: https://github.com/apache/flink/pull/15290


   ## What is the purpose of the change
   
   Fix error where GSR end to end test does not compile in IntelliJ.
   
   ## Brief change log
   
   Removed reference to AWS SDK classes that are shaded by Kinesis client by:
   - Made `KinesisPubsubClient` more generic
   - Delegate GSR Kinesis functionality to the `KinesisPubsubClient`
   
   
   ## Verifying this change
   
   - Run Kinesis e2e tests
   - Run GSR e2e tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15290: [FLINK-21875][hotfix] Fix compilation error in IntelliJ for GSR test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15290:
URL: https://github.com/apache/flink/pull/15290#issuecomment-802870157


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0b9951558f600d9f5c5d75dbdb7be0e25bb6a879",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15071",
       "triggerID" : "0b9951558f600d9f5c5d75dbdb7be0e25bb6a879",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b9951558f600d9f5c5d75dbdb7be0e25bb6a879 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15071) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dannycranmer merged pull request #15290: [FLINK-21875][hotfix] Fix compilation error in IntelliJ for GSR test

Posted by GitBox <gi...@apache.org>.
dannycranmer merged pull request #15290:
URL: https://github.com/apache/flink/pull/15290


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15290: [FLINK-21875][hotfix] Fix compilation error in IntelliJ for GSR test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15290:
URL: https://github.com/apache/flink/pull/15290#issuecomment-802870157


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0b9951558f600d9f5c5d75dbdb7be0e25bb6a879",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15071",
       "triggerID" : "0b9951558f600d9f5c5d75dbdb7be0e25bb6a879",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b9951558f600d9f5c5d75dbdb7be0e25bb6a879 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15071) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #15290: [FLINK-21875][hotfix] Fix compilation error in IntelliJ for GSR test

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15290:
URL: https://github.com/apache/flink/pull/15290#issuecomment-802870157


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0b9951558f600d9f5c5d75dbdb7be0e25bb6a879",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0b9951558f600d9f5c5d75dbdb7be0e25bb6a879",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b9951558f600d9f5c5d75dbdb7be0e25bb6a879 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #15290: [FLINK-21875][hotfix] Fix compilation error in IntelliJ for GSR test

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15290:
URL: https://github.com/apache/flink/pull/15290#issuecomment-802856256


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 0b9951558f600d9f5c5d75dbdb7be0e25bb6a879 (Fri Mar 19 14:02:45 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org