You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@trafficserver.apache.org by SolidWallOfCode <gi...@git.apache.org> on 2015/12/16 23:21:36 UTC

[GitHub] trafficserver pull request: TS-4056: Remove cached netVC from NetA...

GitHub user SolidWallOfCode opened a pull request:

    https://github.com/apache/trafficserver/pull/381

    TS-4056: Remove cached netVC from NetAccept

    This is an updated, rebased version of PR 366[1].
    
    [1] https://github.com/apache/trafficserver/pull/366

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SolidWallOfCode/trafficserver ts-4056

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #381
    
----
commit 416b5673ffe18119569d792729bbb293b459a4be
Author: Oknet <xu...@gmail.com>
Date:   2015-12-07T14:13:42Z

    remove alloc_cache from class NetAccept definition

commit 9c5d82244dce937163527939d689425a0812b359
Author: Oknet <xu...@gmail.com>
Date:   2015-12-07T14:42:27Z

    remove alloc_cache from net_accept()
    
    remove alloc_cache from net_accept() to avoid mem leak on ~NetAccept()

commit a6caf9369ab767e382f94428a8811c03930b074f
Author: Oknet <xu...@gmail.com>
Date:   2015-12-07T14:47:11Z

    fix vc->con to con

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: TS-4056: Remove cached netVC from NetA...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/trafficserver/pull/381


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: TS-4056: Remove cached netVC from NetA...

Posted by shinrich <gi...@git.apache.org>.

Github user shinrich commented on the pull request:

    https://github.com/apache/trafficserver/pull/381#issuecomment-166927897
  
    The change looks good.  I don't see the benefits of the original "pre-allocation" compared to the increased code complexity.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---