You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/08/11 11:55:03 UTC
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #5158: Allow embedded Zookeeper binding IP address
pan3793 commented on code in PR #5158:
URL: https://github.com/apache/kyuubi/pull/5158#discussion_r1291252108
##########
kyuubi-zookeeper/src/main/scala/org/apache/kyuubi/zookeeper/ZookeeperConf.scala:
##########
@@ -49,6 +49,15 @@ object ZookeeperConf {
.stringConf
.createOptional
+ val ZK_CLIENT_USE_HOSTNAME: ConfigEntry[Boolean] =
+ buildConf("kyuubi.zookeeper.embedded.client.use.hostname")
+ .doc("When true, embedded Zookeeper prefer to bind hostname, otherwise, ip address. " +
+ "Note that, the default value is set to `false` when engine running on Kubernetes " +
+ "to prevent potential network issues.")
+ .version("1.7.2")
+ .booleanConf
+ .createWithDefault(true)
Review Comment:
use true to keep behavior, but maybe false is better? since it's not intend to use for production, behavior change is fine.
##########
kyuubi-zookeeper/src/main/scala/org/apache/kyuubi/zookeeper/ZookeeperConf.scala:
##########
@@ -49,6 +49,15 @@ object ZookeeperConf {
.stringConf
.createOptional
+ val ZK_CLIENT_USE_HOSTNAME: ConfigEntry[Boolean] =
+ buildConf("kyuubi.zookeeper.embedded.client.use.hostname")
+ .doc("When true, embedded Zookeeper prefer to bind hostname, otherwise, ip address. " +
+ "Note that, the default value is set to `false` when engine running on Kubernetes " +
+ "to prevent potential network issues.")
+ .version("1.7.2")
+ .booleanConf
+ .createWithDefault(true)
Review Comment:
use true to keep behavior, but maybe false is better? since it's not intended to use for production, behavior change is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org